Skip to content

Zone write plugging fixes

Damien Le Moal dm-devel linux-block 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 5 repliesApplied
  2. v24 patches 9 repliesSuperseded
  3. v14 patches 1 replySuperseded

Changes in v3 from the cover letter

- Added review tags from Christoph to patch 1 and 2.
- Reversed the order of patch 3 and 4. Patch 3 now includes some code that was implemented in "block: Prevent potential deadlocks in zone write plug error recovery" in v2.
- Adjusted and improved the commit messages of patch 3 and 4.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4block: Use a zone write plug BIO work for REQ_NOWAIT BIOsblock/blk-zoned.c+42 -200 replies
2/4block: Ignore REQ_NOWAIT for zone reset and zone finish operationsblock/blk-zoned.c+9 -00 replies
3/4dm: Fix dm-zoned-reclaim zone write pointer alignmentblock/blk-zoned.c drivers/md/dm-zoned-reclaim.c include/linux/blkdev.h+124 -262 replies
4/4block: Prevent potential deadlocks in zone write plug error recoveryblock/blk-zoned.c include/linux/blkdev.h+61 -2491 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristoph HellwigMartin K. PetersenMike Snitzer
SeriesR-b
1/4R-b
2/4R-b
3/4R-b A-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/4] Zone write plugging fixes

Jens,

These patches address potential issues with zone write plugging. The first 2 patches fix handling of REQ_NOWAIT BIOs as these can be "failed" after going through the zone write plugging and changing the target zone plug zone write pointer offset.

Patch 3 is a bigger fix and address a potential deadlock issue due to the zone write plugging internally issuing zone report operations to recover from write errors. This zone report operation is removed by this patch and replaced with an automatic recovery when the BIO issuer execute a zone report. This change in behavior results in a problem with REQ_OP_WRITE_ZEROES handling and failures in the dm-zoned device mapper. That is fixed in patch 4.

I will followup these fixes with a cleanup of the report zones API and its callback function interface to clean it up as patch 4 introduces an indirect user callback call that is not very pretty.

Changes from v2:
- Added review tags from Christoph to patch 1 and 2.
- Reversed the order of patch 3 and 4. Patch 3 now includes some code that was implemented in "block: Prevent potential deadlocks in zone write plug error recovery" in v2.
- Adjusted and improved the commit messages of patch 3 and 4.

Changes from v1:
- Fixed kdoc comment for blkdev_issue_zone_zeroout() in patch 4

Damien Le Moal (4):
block: Use a zone write plug BIO work for REQ_NOWAIT BIOs
block: Ignore REQ_NOWAIT for zone reset and zone finish operations
dm: Fix dm-zoned-reclaim zone write pointer alignment
block: Prevent potential deadlocks in zone write plug error recovery

 block/blk-zoned.c             | 506 +++++++++++++++-------------------
 drivers/md/dm-zoned-reclaim.c |   6 +-
 include/linux/blkdev.h        |   5 +-
 3 files changed, 229 insertions(+), 288 deletions(-)
Signature · 1 line
2.47.1