arm64: dts: qcom: x1e80100: fix USB OTG regressions
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Changes in v3 from the cover letter
- revert also the dtsi change that enable role-switching since it breaks UCSI (and DisplayPort alt mode) when the controllers are in host mode
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports"arch/ | +8 | 1 reply | |
| 2/3 | Revert "arm64: dts: qcom: x1e80100-crd: enable otg on usb ports"arch/ | +12 | 1 reply | |
| 3/3 | Revert "arm64: dts: qcom: x1e80100: enable OTG on USB-C controllers"arch/ | +0 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Abel Vesa |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/3] arm64: dts: qcom: x1e80100: fix USB OTG regressions
A recent change enabling OTG mode on the Lenovo ThinkPad T14s USB-C ports can break SuperSpeed device hotplugging.
Abel noticed that the corresponding commit for the CRD also triggers a hard reset during resume from suspend.
Dmitry had already reported that enabling role switching can break UCSI.
With retimer (and orientation detection) support not even merged yet, let's revert at least until we have stable host mode in mainline.
Note that Stephan has also identified other problems with the offending commits here:
https://lore.kernel.org/all/[email protected]/
Johan
Changes in v3
- revert also the dtsi change that enable role-switching since it breaks UCSI (and DisplayPort alt mode) when the controllers are in host mode
Changes in v2
- revert also the corresponding patch for the CRD which breaks suspend
Johan Hovold (3):
Revert "arm64: dts: qcom: x1e78100-t14s: enable otg on usb-c ports" Revert "arm64: dts: qcom: x1e80100-crd: enable otg on usb ports" Revert "arm64: dts: qcom: x1e80100: enable OTG on USB-C controllers"
.../boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 8 ++++++++ arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 12 ++++++++++++ arch/arm64/boot/dts/qcom/x1e80100.dtsi | 6 ------ 3 files changed, 20 insertions(+), 6 deletions(-)
Signature · 1 line
2.45.2