Skip to content

GuC changes for flicker-free boot.

Maarten Lankhorst intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/xe/display: Add intel_plane_initial_vblank_waitdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_plane_initial.c drivers/gpu/drm/i915/display/intel_plane_initial.h +1 more+29 -51 reply
2/11drm/xe: Remove double pageflipdrivers/gpu/drm/xe/display/xe_plane_initial.c+0 -100 replies
3/11drm/xe: Move suballocator init to after display initdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_tile.c drivers/gpu/drm/xe/xe_tile.h+15 -40 replies
4/11drm/xe: Defer irq init until after xe_display_init_noacceldrivers/gpu/drm/xe/xe_device.c+4 -41 reply
5/11drm/xe/display: Use a single early init call for displaydrivers/gpu/drm/xe/display/xe_display.c drivers/gpu/drm/xe/display/xe_display.h drivers/gpu/drm/xe/xe_device.c+22 -690 replies
6/11drm/xe: Defer memirq init until neededdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_tile.c+7 -42 replies
7/11drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_initdrivers/gpu/drm/xe/xe_gt_sriov_vf.c drivers/gpu/drm/xe/xe_guc.c+9 -91 reply
8/11drm/xe: Simplify GuC early initialisationdrivers/gpu/drm/xe/tests/xe_guc_relay_test.c drivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_gt.c +9 more+88 -511 reply
9/11drm/xe: Make it possible to read instance0 MCR registers after xe_gt_mcr_init_earlydrivers/gpu/drm/xe/xe_gt_mcr.c drivers/gpu/drm/xe/xe_gt_types.h+29 -202 replies
10/11drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_earlydrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_gt.c drivers/gpu/drm/xe/xe_gt.h+32 -413 replies
11/11drm/xe: Do not attempt to bootstrap VF in execlists modedrivers/gpu/drm/xe/xe_gt_sriov_vf.c+3 -01 reply

Reviews trailers per patch

7 of 11 patches have a Reviewed-by or Acked-by.

PatchRodrigo ViviVinod GovindapillaiLucas De MarchiIlia LeviMatt Roper
1/11
2/11R-b R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b R-b
7/11
8/11
9/11R-b
10/11
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/11] GuC changes for flicker-free boot.

Ignore the first 5 patches in this series, it's sent as a separate series.
https://patchwork.freedesktop.org/series/142241/
I would like review on patch 6-10 instead, those are the changes related to the GuC init sequence.

Instead of all the separate steps, the init sequence is simplified and made more uniform. We create a xe_guc_init_noalloc that performs all early initialisation required to make VF work. We also initialise the MCR instance 0 registers for VRAM readout, later on we enable the other MCR registers.

Maarten Lankhorst (11):
drm/xe/display: Add intel_plane_initial_vblank_wait drm/xe: Remove double pageflip
drm/xe: Move suballocator init to after display init drm/xe: Defer irq init until after xe_display_init_noaccel drm/xe/display: Use a single early init call for display drm/xe: Defer memirq init until needed
drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init drm/xe: Simplify GuC early initialisation
drm/xe: Make it possible to read instance0 MCR registers after
xe_gt_mcr_init_early
drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early drm/xe: Do not attempt to bootstrap VF in execlists mode

 drivers/gpu/drm/i915/display/intel_display.c  |  6 +-
 .../drm/i915/display/intel_plane_initial.c    |  7 +-
 .../drm/i915/display/intel_plane_initial.h    |  2 +
 drivers/gpu/drm/xe/display/xe_display.c       | 73 +++++--------------
 drivers/gpu/drm/xe/display/xe_display.h       |  8 +-
 drivers/gpu/drm/xe/display/xe_plane_initial.c | 29 +++++---
 drivers/gpu/drm/xe/tests/xe_guc_relay_test.c  |  2 +-
 drivers/gpu/drm/xe/xe_device.c                | 50 +++----------
 drivers/gpu/drm/xe/xe_gt.c                    | 73 ++++++++++---------
 drivers/gpu/drm/xe/xe_gt.h                    |  1 -
 drivers/gpu/drm/xe/xe_gt_mcr.c                | 47 +++++++-----
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c           |  4 +-
 drivers/gpu/drm/xe/xe_gt_types.h              |  2 +
 drivers/gpu/drm/xe/xe_guc.c                   | 56 ++++++++------
 drivers/gpu/drm/xe/xe_guc.h                   |  1 +
 drivers/gpu/drm/xe/xe_guc_ct.c                | 28 ++++---
 drivers/gpu/drm/xe/xe_guc_ct.h                |  1 +
 drivers/gpu/drm/xe/xe_guc_relay.c             |  6 +-
 drivers/gpu/drm/xe/xe_guc_relay.h             |  2 +-
 drivers/gpu/drm/xe/xe_huc.h                   |  1 +
 drivers/gpu/drm/xe/xe_tile.c                  | 19 ++++-
 drivers/gpu/drm/xe/xe_tile.h                  |  1 +
 drivers/gpu/drm/xe/xe_uc.c                    | 21 ++++++
 drivers/gpu/drm/xe/xe_uc.h                    |  1 +
 24 files changed, 231 insertions(+), 210 deletions(-)
Signature · 1 line
2.45.2