Skip to content

mfd: syscon: Cleanup, fix race condition and remove platform driver

Rob Herring (Arm) asahi linux-arm-kernel lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected] change-id 20241211-syscon-fixes-9f35ecb9bfbe

Versions newest first

  1. v2 Latest3 patches 14 repliesApplied
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Fix patch 3 logic when a syscon is found in list to not return an
error
- Add tags
- Link to v1: https://lore.kernel.org/r/[email protected]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3mfd: syscon: Fix race in device_node_get_regmap()drivers/mfd/syscon.c+10 -93 replies
2/3mfd: syscon: Remove the platform driver supportdrivers/mfd/syscon.c drivers/mfd/vexpress-sysreg.c include/linux/platform_data/syscon.h+0 -765 replies
3/3mfd: syscon: Allow syscon nodes without a "syscon" compatibledrivers/mfd/syscon.c+6 -65 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiWill McVickerLiviu DudauPankaj Dubey
1/3R-b T-b T-b T-b R-b
2/3T-b R-b T-b A-b R-b T-b
3/3R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] mfd: syscon: Cleanup, fix race condition and remove platform driver

Questions from Krzysztof and a syscon related binding review got me looking at the syscon "driver". This series is the result.

This short series drops the stale platform driver part of syscon support, fixes a race condition in device_node_get_regmap() which is used by all the lookup functions, and allows for registering nodes without "syscon" compatibles.

Compile tested only. Testing on Tensor, the one user of of_syscon_register_regmap(), would be helpful.

---
Changes in v2:
- Fix patch 3 logic when a syscon is found in list to not return an
error
- Add tags
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Rob Herring (Arm) (3):
mfd: syscon: Fix race in device_node_get_regmap()
mfd: syscon: Remove the platform driver support
mfd: syscon: Allow syscon nodes without a "syscon" compatible

 drivers/mfd/syscon.c                 | 95 ++++++------------------------------
 drivers/mfd/vexpress-sysreg.c        |  1 -
 include/linux/platform_data/syscon.h |  9 ----
 3 files changed, 15 insertions(+), 90 deletions(-)

---
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
change-id: 20241211-syscon-fixes-9f35ecb9bfbe

Best regards,

Signature · 1 line
Rob Herring (Arm) <[email protected]>