Skip to content

usb/msd: Permit relaxed ordering of IN packets

Nicholas Piggin qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 11 repliesIn review
  2. v111 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10usb/msd: Split in and out packet handlinghw/usb/dev-storage.c+145 -1210 replies
2/10usb/msd: Ensure packet structure layout is correcthw/usb/dev-storage.c+4 -14 replies
3/10usb/msd: Improved handling of mass storage resethw/usb/dev-storage.c+1 -11 reply
4/10usb/msd: Improve packet validation error logginghw/usb/dev-storage.c+42 -110 replies
5/10usb/msd: Allow CBW packet size greater than 31hw/usb/dev-storage.c+1 -10 replies
6/10usb/msd: Split async packet tracking into data and cswhw/usb/dev-storage.c include/hw/usb/msd.h+79 -470 replies
7/10usb/msd: Add some additional assertionshw/usb/dev-storage.c+19 -41 reply
8/10usb/msd: Rename mode to cbw_state, and tweak nameshw/usb/dev-storage.c include/hw/usb/msd.h+32 -303 replies
9/10usb/msd: Permit a DATA-IN or CSW packet before CBW packethw/usb/dev-storage.c include/hw/usb/msd.h+44 -00 replies
10/10usb/msd: Add more tracinghw/usb/dev-storage.c hw/usb/trace-events+29 -32 replies

Reviews trailers per patch

5 of 10 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/10
2/10R-b
3/10R-b
4/10
5/10
6/10
7/10R-b
8/10R-b
9/10
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] usb/msd: Permit relaxed ordering of IN packets

This series ultimately permits relaxed ordering of USB mass-storage packets from the host, as allowed by the usbmassbulk 1.0 spec, but not usually seen in drivers. AIX drivers do require this ordering.

Since v1:

https://lore.kernel.org/qemu-devel/[email protected]/

- Rebased on upstream with one patch from the series merged.
- Fixed a few build warnings on 32-bit hosts.

Thanks,
Nick

Nicholas Piggin (10):
usb/msd: Split in and out packet handling usb/msd: Ensure packet structure layout is correct usb/msd: Improved handling of mass storage reset usb/msd: Improve packet validation error logging usb/msd: Allow CBW packet size greater than 31 usb/msd: Split async packet tracking into data and csw usb/msd: Add some additional assertions
usb/msd: Rename mode to cbw_state, and tweak names usb/msd: Permit a DATA-IN or CSW packet before CBW packet usb/msd: Add more tracing

 include/hw/usb/msd.h |  18 +-
 hw/usb/dev-storage.c | 510 ++++++++++++++++++++++++++++---------------
 hw/usb/trace-events  |   9 +-
 3 files changed, 357 insertions(+), 180 deletions(-)
Signature · 1 line
2.47.1