Skip to content

drm/{i915,xe}: Convert to DRM client setup

Thomas Zimmermann dri-devel intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/{i915, xe}: Suspend/resume fbdev emulation via client interfacesdrivers/gpu/drm/i915/display/intel_fbdev.c drivers/gpu/drm/i915/i915_driver.c drivers/gpu/drm/xe/display/xe_display.c+26 -82 replies
2/12drm/client: Add client-hotplug helperdrivers/gpu/drm/drm_client_event.c+19 -130 replies
3/12drm/client: Send pending hotplug events after resumedrivers/gpu/drm/drm_client_event.c include/drm/drm_client.h+17 -00 replies
4/12drm/i915/display: Remove fbdev suspend and hotplug trackingdrivers/gpu/drm/i915/display/intel_fbdev.c+2 -610 replies
5/12drm/i915/display: fbdev: Move custom restore code to new callbackdrivers/gpu/drm/drm_fb_helper.c drivers/gpu/drm/i915/display/intel_fbdev.c include/drm/drm_fb_helper.h+24 -20 replies
6/12drm/i915/display: fbdev: Move custom suspend code to new callbackdrivers/gpu/drm/drm_fb_helper.c drivers/gpu/drm/i915/display/intel_fbdev.c include/drm/drm_fb_helper.h+38 -130 replies
7/12drm/i915/display: Remove preferred_bpp from struct intel_fbdevdrivers/gpu/drm/i915/display/intel_fbdev.c+23 -60 replies
8/12drm/i915/display: Remove struct drm_fb_helper from struct intel_fbdevdrivers/gpu/drm/i915/display/intel_fbdev.c+28 -210 replies
9/12drm/i915/display: Move fbdev code arounddrivers/gpu/drm/i915/display/intel_fbdev.c+44 -410 replies
10/12drm/{i915,xe}: Run DRM default client setupdrivers/gpu/drm/i915/display/intel_display_core.h drivers/gpu/drm/i915/display/intel_fbdev.c drivers/gpu/drm/i915/display/intel_fbdev.h +2 more+21 -1993 replies
11/12drm/i915/display: Remove compile guard around fbdev debugfs outputdrivers/gpu/drm/i915/display/intel_display_debugfs.c+0 -20 replies
12/12drm/fb-helper: Remove struct drm_fb_helper.fb_probedrivers/gpu/drm/drm_fb_helper.c include/drm/drm_fb_helper.h+4 -210 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRodrigo ViviMaarten Lankhorst
SeriesR-b
1/12R-b
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] drm/{i915,xe}: Convert to DRM client setup

i915 and xe are the last remaining drivers that still implement their own fbdev client. All other clients have been mass converted to DRM's client setup in in the series at [1]. As Intel drivers require more effort than others, their changes have been moved into this separate series.

With DRM's client setup, DRM picks the in-kernel client from the kernel's config and parameters. Besides fbdev there's also drm_log available. For fbdev support, the driver only has to implement struct drm_driver.fbdev_probe, a callback that allocates a compatible framebuffer.

At first, some details of the Intel implementation have to be rebuild for the generic client and fbdev handling. Patches 1 to 6 do that. Hotplugging and suspend/resume are then hidden behind callbacks. Some Intel-specifics in the restore and suspend code get their own hooks.

Patches 7 to 9 prepare Intel's fbdev implementation ot get things out of the way.

Patch 10 converts i915 and xe to DRM's client setup. Patches 11 and 12 clean up the remaining code.

Tested with i915 and xe hardware.

[1] https://patchwork.freedesktop.org/series/137391/

Thomas Zimmermann (12):
drm/{i915,xe}: Suspend/resume fbdev emulation via client interfaces drm/client: Add client-hotplug helper
drm/client: Send pending hotplug events after resume drm/i915/display: Remove fbdev suspend and hotplug tracking drm/i915/display: fbdev: Move custom restore code to new callback drm/i915/display: fbdev: Move custom suspend code to new callback drm/i915/display: Remove preferred_bpp from struct intel_fbdev drm/i915/display: Remove struct drm_fb_helper from struct intel_fbdev drm/i915/display: Move fbdev code around
drm/{i915,xe}: Run DRM default client setup drm/i915/display: Remove compile guard around fbdev debugfs output drm/fb-helper: Remove struct drm_fb_helper.fb_probe

 drivers/gpu/drm/drm_client_event.c            |  41 ++-
 drivers/gpu/drm/drm_fb_helper.c               |  20 +-
 .../gpu/drm/i915/display/intel_display_core.h |   1 -
 .../drm/i915/display/intel_display_debugfs.c  |   2 -
 drivers/gpu/drm/i915/display/intel_fbdev.c    | 338 ++++--------------
 drivers/gpu/drm/i915/display/intel_fbdev.h    |  17 +-
 drivers/gpu/drm/i915/i915_driver.c            |  10 +-
 drivers/gpu/drm/xe/display/xe_display.c       |  12 +-
 include/drm/drm_client.h                      |   8 +
 include/drm/drm_fb_helper.h                   |  44 ++-
 10 files changed, 176 insertions(+), 317 deletions(-)

base-commit: 7bbcd7df9387f0d9004f997df33f7a9472d9c080

Signature · 1 line
2.47.1