Skip to content

iomap: incremental per-operation iter advance

Brian Foster linux-fsdevel linux-xfs 6 versions – Applied

Status from this message: Applied to the vfs-6.15.iomap branch of the vfs/vfs.git tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest10 patches 4 repliesApplied
  2. v510 patches 14 repliesSuperseded
  3. v410 patches 10 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches4 repliesSuperseded
v27 patches14 repliesSuperseded
v16 patches11 repliesSuperseded

Changes in v6 from the cover letter · 17 lines

- Comment updates in patches 6 and 7.
v5: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Fixed refactoring bug in v4 by pulling 'processed' local var into patch 4.
v4: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Reordered patches 1 and 2 to keep iter advance cleanups together.
- Split patch 3 from v3 into patches 3-6.
v3: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Code style and comment fixups.
- Variable type fixups and rework of iomap_iter_advance() to return error/length separately.
- Advance the iter on unshare and zero range skip cases instead of returning length.
v2: https://lore.kernel.org/linux-fsdevel/[email protected]/
- More refactoring of iomap_iter[_advance]() logic. Lifted out iter continuation and stale logic and improved comments.
- Renamed some poorly named helpers and variables.
- Return remaining length for current iter from _iter_advance() and use appropriately.
v1: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Reworked and fixed a bunch of functional issues.
RFC: https://lore.kernel.org/linux-fsdevel/[email protected]/

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/10iomap: factor out iomap length helperinclude/linux/iomap.h+19 -40 replies
2/10iomap: split out iomap check and reset logic from iter advancefs/iomap/iter.c+26 -230 replies
3/10iomap: refactor iomap_iter() length check and tracepointfs/iomap/iter.c+11 -80 replies
4/10iomap: lift error code check out of iomap_iter_advance()fs/iomap/iter.c+8 -30 replies
5/10iomap: lift iter termination logic from iomap_iter_advance()fs/iomap/iter.c+13 -80 replies
6/10iomap: export iomap_iter_advance() and return remaining lengthfs/iomap/iter.c include/linux/iomap.h+9 -141 reply
7/10iomap: support incremental iomap_iter advancesfs/iomap/iter.c include/linux/iomap.h+31 -91 reply
8/10iomap: advance the iter directly on buffered writesfs/iomap/buffered-io.c+7 -130 replies
9/10iomap: advance the iter directly on unshare rangefs/iomap/buffered-io.c+11 -120 replies
10/10iomap: advance the iter directly on zero rangefs/iomap/buffered-io.c+13 -110 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigDarrick J. Wong
1/10R-b R-b
2/10R-b R-b
3/10R-b R-b
4/10R-b R-b
5/10R-b R-b
6/10R-b R-b
7/10R-b R-b
8/10R-b R-b
9/10R-b R-b
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/10] iomap: incremental per-operation iter advance

Hi all,

Just a couple comment changes, no code changes from v5.

Brian

v6:
- Comment updates in patches 6 and 7.
v5: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Fixed refactoring bug in v4 by pulling 'processed' local var into patch 4.
v4: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Reordered patches 1 and 2 to keep iter advance cleanups together.
- Split patch 3 from v3 into patches 3-6.
v3: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Code style and comment fixups.
- Variable type fixups and rework of iomap_iter_advance() to return error/length separately.
- Advance the iter on unshare and zero range skip cases instead of returning length.
v2: https://lore.kernel.org/linux-fsdevel/[email protected]/
- More refactoring of iomap_iter[_advance]() logic. Lifted out iter continuation and stale logic and improved comments.
- Renamed some poorly named helpers and variables.
- Return remaining length for current iter from _iter_advance() and use appropriately.
v1: https://lore.kernel.org/linux-fsdevel/[email protected]/
- Reworked and fixed a bunch of functional issues.
RFC: https://lore.kernel.org/linux-fsdevel/[email protected]/

Brian Foster (10):
iomap: factor out iomap length helper
iomap: split out iomap check and reset logic from iter advance
iomap: refactor iomap_iter() length check and tracepoint
iomap: lift error code check out of iomap_iter_advance()
iomap: lift iter termination logic from iomap_iter_advance()
iomap: export iomap_iter_advance() and return remaining length
iomap: support incremental iomap_iter advances
iomap: advance the iter directly on buffered writes
iomap: advance the iter directly on unshare range
iomap: advance the iter directly on zero range

 fs/iomap/buffered-io.c |  67 +++++++++++++--------------
 fs/iomap/iter.c        | 102 ++++++++++++++++++++++++++---------------
 include/linux/iomap.h  |  32 ++++++++++---
 3 files changed, 122 insertions(+), 79 deletions(-)
Signature · 1 line
2.48.1