Skip to content

Fix XDR encoding near page boundaries

[email protected] linux-nfs 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 4 repliesIn review
  2. v36 patches 4 repliesSuperseded
  3. v22 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC1 patch4 repliesSuperseded

Changes since v2 from the cover letter

- Address same issue in NFSv4 READLINK and SECINFO operations
- Update kdoc comment for xdr_reserve_space()

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9NFSD: Encode COMPOUND operation status on page boundariesfs/nfsd/nfs4xdr.c+10 -100 replies
2/9NFSD: Insulate nfsd4_encode_read() from page boundaries in the encode bufferfs/nfsd/nfs4xdr.c+19 -150 replies
3/9NFSD: Insulate nfsd4_encode_read_plus() from page boundaries in the encode bufferfs/nfsd/nfs4xdr.c+10 -80 replies
4/9NFSD: Insulate nfsd4_encode_read_plus_data() from page boundaries in the encode bufferfs/nfsd/nfs4xdr.c+17 -80 replies
5/9NFSD: Insulate nfsd4_encode_fattr4() from page boundaries in the encode bufferfs/nfsd/nfs4xdr.c+6 -60 replies
6/9NFSD: Insulate nfsd4_encode_readlink() from page boundaries in the encode bufferfs/nfsd/nfs4xdr.c+10 -120 replies
7/9NFSD: Refactor nfsd4_do_encode_secinfo() againfs/nfsd/nfs4xdr.c+34 -310 replies
8/9NFSD: Insulate nfsd4_encode_secinfo() from page boundaries in the encode bufferfs/nfsd/nfs4xdr.c+10 -80 replies
9/9SUNRPC: Document validity guarantees of the pointer returned by reserve_spacenet/sunrpc/xdr.c+6 -03 replies

Reviews trailers per patch

2 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRick MacklemNeilBrownJeff Layton
SeriesR-b
1/9T-b R-b
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/9] Fix XDR encoding near page boundaries

From: Chuck Lever <[email protected]>

Refresh the patch series to address the longstanding bug pointed out by J David and Rick Macklem.

Changes since v2:
- Address same issue in NFSv4 READLINK and SECINFO operations
- Update kdoc comment for xdr_reserve_space()

Chuck Lever (9):
NFSD: Encode COMPOUND operation status on page boundaries
NFSD: Insulate nfsd4_encode_read() from page boundaries in the encode
buffer
NFSD: Insulate nfsd4_encode_read_plus() from page boundaries in the
encode buffer
NFSD: Insulate nfsd4_encode_read_plus_data() from page boundaries in
the encode buffer
NFSD: Insulate nfsd4_encode_fattr4() from page boundaries in the
encode buffer
NFSD: Insulate nfsd4_encode_readlink() from page boundaries in the
encode buffer
NFSD: Refactor nfsd4_do_encode_secinfo() again
NFSD: Insulate nfsd4_encode_secinfo() from page boundaries in the
encode buffer
SUNRPC: Document validity guarantees of the pointer returned by
reserve_space

 fs/nfsd/nfs4xdr.c | 214 +++++++++++++++++++++++++---------------------
 net/sunrpc/xdr.c  |   6 ++
 2 files changed, 122 insertions(+), 98 deletions(-)
Signature · 1 line
2.47.0