Skip to content

hwmon: (oxpsensors) Add devices, features, fix ABI and move to platform/x86

Antheas Kapenekakis linux-doc linux-hwmon linux-pm lkml platform-driver-x86 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest16 patches 1 replyIn review
  2. v915 patches 4 repliesSuperseded
  3. v814 patches 14 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v714 patches2 repliesSuperseded
v614 patches5 repliesSuperseded
v513 patches10 repliesSuperseded
v413 patches13 repliesSuperseded
v312 patches19 repliesSuperseded
v212 patches10 repliesSuperseded
v110 patches7 repliesSuperseded

Changes in v10 from the cover letter

- Reflow commit texts
- Use tabs for all defines (with extra patch)
- Reflow some function headers

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16hwmon: (oxp-sensors) Distinguish the X1 variantsdrivers/hwmon/oxp-sensors.c+22 -10 replies
2/16hwmon: (oxp-sensors) Add all OneXFly variantsdrivers/hwmon/oxp-sensors.c+35 -00 replies
3/16platform/x86: oxpec: Move hwmon/oxp-sensors to platform/x86Documentation/hwmon/index.rst Documentation/hwmon/oxp-sensors.rst MAINTAINERS +5 more+24 -1110 replies
4/16ABI: testing: sysfs-class-oxp: add missing documentationDocumentation/ABI/testing/sysfs-platform-oxp+13 -00 replies
5/16ABI: testing: sysfs-class-oxp: add tt_led attribute documentationDocumentation/ABI/testing/sysfs-platform-oxp+12 -00 replies
6/16platform/x86: oxpec: Rename ec group to tt_toggledrivers/platform/x86/oxpec.c+4 -40 replies
7/16platform/x86: oxpec: Add turbo led support to X1 devicesdrivers/platform/x86/oxpec.c+84 -00 replies
8/16platform/x86: oxpec: Move pwm_enable read to its own functiondrivers/platform/x86/oxpec.c+27 -230 replies
9/16platform/x86: oxpec: Move pwm value read/write to separate functionsdrivers/platform/x86/oxpec.c+88 -750 replies
10/16platform/x86: oxpec: Move fan speed read to separate functiondrivers/platform/x86/oxpec.c+29 -240 replies
11/16platform/x86: oxpec: Adhere to sysfs-class-hwmon and enable pwm on 2drivers/platform/x86/oxpec.c+33 -40 replies
12/16platform/x86: oxpec: Follow reverse xmas convention for tt_toggledrivers/platform/x86/oxpec.c+4 -40 replies
13/16power: supply: add inhibit-charge-awake to charge_behaviourDocumentation/ABI/testing/sysfs-class-power drivers/power/supply/power_supply_sysfs.c drivers/power/supply/test_power.c +1 more+12 -80 replies
14/16platform/x86: oxpec: Add charge threshold and behaviour to OneXPlayerdrivers/platform/x86/Kconfig drivers/platform/x86/oxpec.c+152 -10 replies
15/16platform/x86: oxpec: Rename rval to ret in tt_toggledrivers/platform/x86/oxpec.c+8 -80 replies
16/16platform/x86: oxpec: Convert defines to using tabsdrivers/platform/x86/oxpec.c+18 -180 replies

Reviews trailers per patch

14 of 16 patches have a Reviewed-by or Acked-by.

PatchDerek J. ClarkGuenter RoeckThomas WeißschuhIlpo JärvinenHans de Goede
1/16R-b A-b R-b R-b
2/16R-b A-b R-b R-b
3/16R-b A-b R-b
4/16R-b R-b
5/16R-b R-b
6/16R-b R-b R-b
7/16R-b R-b
8/16R-b R-b R-b
9/16R-b R-b R-b
10/16R-b R-b R-b
11/16R-b R-b
12/16R-b R-b R-b
13/16R-b R-b R-b
14/16R-b R-b
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v10 thread

Cover letter [PATCH v10 00/16] hwmon: (oxpsensors) Add devices, features, fix ABI and move to platform/x86

This four part series updates the oxpsensors module to bring it in line with its Windows OneXPlayer counterpart. First, it adds support for all 2024, 2025 OneXPlayer handhelds and their special variants. Then, it moves the module to platform/x86 to allow for including more EC features.

Then, it adds the new charge limiting and bypass features that were first introduced in the X1 and retrofit to older OneXFly variants and for controlling the turbo led found in the X1 models. For Bypass, it adds a new charge_behaviour variant called inhibit-charge-s0.

Finally, it performs a minor refactor by moving around switch statements into their own functions, in order to allow for fixing the pwm1_enable ABI in the final patch. Currently, pwm1_enable sets the fan to auto with the value 0 and allows manual control with the value 1. This patch makes it so 0 sets the fan to full speed, 1 sets the fan to manual control, and 2 sets the fan to auto. This requires both setting enable and the fan speed when the enable sysfs is written to as 0, hence the refactor.

As this is a minor ABI break and there is userspace software relying on this previous behavior, the last patch also changes the /name of the hwmon endpoint to "oxp_ec" from "oxpec" (mirroring WMI module conventions) such that userspace software that relied on the previous behavior can be retrofit to the new kernel while enabling correct functionality on old and new kernels. Failing that, software that is not updated will just stop controlling the fans, ensuring no malignant behavior.

---
V9: https://lore.kernel.org/all/[email protected]/
V8: https://lore.kernel.org/all/[email protected]/
V7: https://lore.kernel.org/all/[email protected]/
V6: NA
V5: https://lore.kernel.org/all/[email protected]/
V4: https://lore.kernel.org/all/[email protected]/
V3: https://lore.kernel.org/all/[email protected]/

Changes since V9:
- Reflow commit texts
- Use tabs for all defines (with extra patch)
- Reflow some function headers

Changes since V8:
- Fix nits by Ilpo
- No functionality changes (battery check was a NOOP)

Changes since V7:
- Add rename to ABI switch patch, for rebase friendliness (this is moreso for my sanity as I will be the one rebasing)
- Fix 2 other nits by Thomas

Changes since V6:
- Fix compile error due to extra const. My bad on that one, did a double check on a device too.

Changes since V5:
- Separate doc entries with Fixes as by Mario
- Add sysfs file name to subject as per Thomas
- Make tt_led and tt_turbo const as per Thomas
- Align a couple of structs as per Thomas
- Remove excess battery check as per Thomas
- For Thomas: devices without a BIOS update battery control is a NOOP OXP is a boutique manufacturer for now, so gathering information about old devices to add BIOS checks is not practical unfortunately

Changes since V4:
- Fix nits by Hans
- change inhibit-charge-s0 to inhibit-charge-awake
- use devm_battery_hook_register and power_supply_unregister_extension (based on cros driver)
- move charge behavior patches to the end to make the rest of the series easier to merge
- CC platform-x86 and power maintainers

Changes since V3:
- Fix nits by Derek
- Remove the hwmon documentation as it is not required for platform drivers (suggested by Guenter)
- Add ACPI_BATTERY and HWMON depends to Kconfig (reported by kernel robot)
- Homogenize driver into following reverse xmas convention

Changes since V2:
- Add ack by Guenter, move platform move patch to be third (not first to allow for device support backport to lts kernels)
- Rework patch text, especially in the refactor patches as per Derek
- Change bypass to use charge_behaviour instead of charge_type, as that ABI supports capability detection and is more appropriate
- Move battery attach to probe instead of init
- Fix bug where reading tt_led would instead use the turbo register

Changes since V1:
- Add X1 Pro, F1 Pro variants
- Fix minor typo in initial patches
- Convert oxp-sensors into a platform driver, as it is no longer considered a hwmon driver.
- Add sysfs documentation and myself to the MAINTAINERS file
- Update documentation to state that this is the OneXPlayer/AOKZOE platform driver, and that support for Ayaneo/OPI is provided until they gain their own platform driver.

Antheas Kapenekakis (16):
hwmon: (oxp-sensors) Distinguish the X1 variants
hwmon: (oxp-sensors) Add all OneXFly variants platform/x86: oxpec: Move hwmon/oxp-sensors to platform/x86
ABI: testing: sysfs-class-oxp: add missing documentation
ABI: testing: sysfs-class-oxp: add tt_led attribute documentation platform/x86: oxpec: Rename ec group to tt_toggle platform/x86: oxpec: Add turbo led support to X1 devices platform/x86: oxpec: Move pwm_enable read to its own function platform/x86: oxpec: Move pwm value read/write to separate functions platform/x86: oxpec: Move fan speed read to separate function platform/x86: oxpec: Adhere to sysfs-class-hwmon and enable pwm on 2 platform/x86: oxpec: Follow reverse xmas convention for tt_toggle
power: supply: add inhibit-charge-awake to charge_behaviour platform/x86: oxpec: Add charge threshold and behaviour to OneXPlayer platform/x86: oxpec: Rename rval to ret in tt_toggle platform/x86: oxpec: Convert defines to using tabs

 Documentation/ABI/testing/sysfs-class-power  |   11 +-
 Documentation/ABI/testing/sysfs-platform-oxp |   25 +
 Documentation/hwmon/index.rst                |    2 +-
 Documentation/hwmon/oxp-sensors.rst          |   89 --
 MAINTAINERS                                  |    7 +-
 drivers/hwmon/Kconfig                        |   11 -
 drivers/hwmon/Makefile                       |    1 -
 drivers/hwmon/oxp-sensors.c                  |  716 ------------
 drivers/platform/x86/Kconfig                 |   13 +
 drivers/platform/x86/Makefile                |    3 +
 drivers/platform/x86/oxpec.c                 | 1055 ++++++++++++++++++
 drivers/power/supply/power_supply_sysfs.c    |    7 +-
 drivers/power/supply/test_power.c            |    1 +
 include/linux/power_supply.h                 |    1 +
 14 files changed, 1113 insertions(+), 829 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-platform-oxp
 delete mode 100644 Documentation/hwmon/oxp-sensors.rst
 delete mode 100644 drivers/hwmon/oxp-sensors.c
 create mode 100644 drivers/platform/x86/oxpec.c

base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b

Signature · 1 line
2.49.0