Skip to content

iio: magnetometer: add support for Si7210

Antoni Pokusinski linux-devicetree linux-iio lkml 5 versions – Applied

Status from this message: Applied to the togreg branch of iio.git but initially only pushed out

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 1 replyApplied
  2. v42 patches 6 repliesSuperseded
  3. v32 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches2 repliesSuperseded
v12 patches2 repliesSuperseded

Changes in v5 from the cover letter

* Makefile: replace spaces/tabs mixture with tabs only
* si7210: includes: move asm/byteorder.h to the end
* si7210: read_raw: add comments for temperature calculation

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/2dt-bindings: iio: magnetometer: add binding for Si7210Documentation/devicetree/bindings/iio/magnetometer/silabs,si7210.yaml+48 -00 replies
2/2iio: magnetometer: si7210: add driver for Si7210drivers/iio/magnetometer/Kconfig drivers/iio/magnetometer/Makefile drivers/iio/magnetometer/si7210.c+459 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiAndy Shevchenko
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] iio: magnetometer: add support for Si7210

This patch series adds support for the Si7210 Hall effect I2C sensor. The driver currently supports the basic functionalities (i.e. making temperature and magnetic field measurements and changing the measurements scale) but I plan to add support for some other features in the future as well (e.g. the digital output interrupt).

---
Hi all,
In this version I add only some minor tweaks and comments (for the temperature calculation) according to the latest review. Everything else was left intact.

Kind regards,
Antoni

Changes since v4:
* Makefile: replace spaces/tabs mixture with tabs only
* si7210: includes: move asm/byteorder.h to the end
* si7210: read_raw: add comments for temperature calculation

Changes since v3:
* si7210: fetch_measurement/read_raw: fix issue with endianess
* si7210: replace if (ret < 0) with if (ret) wherever possible
* si7210: read_raw: use SI metric prefixes (MICRO, MILLI)
* si7210: si7210_data: swap i2c_client with regmap
* si7210: read_otpreg_val: remove unnecessary cast
* si7210: minor formatting updates
(add missing trailing commas, spaces etc)
* si7210: probe: use devm_mutex_init
* si7210: add missing includes

Changes since v2:
* Makefile: fix alignment
* si7210: fetch_measurement: use temporary variable to read the measurement instead of reading directly to buf
* si7210: read_raw: change tmp to temp
* si7210: read_raw: adjust temperature computation to match the spec better
* si7210: device_wake: do not init ret to 0
* si7210: MODULE_LICENSE: change license type to GPL
* si7210: minor improvements in comments

Changes since v1:
* dt-binding: add vdd-supply
* si7210: reorder includes in alphabetic order
* si7210: add comment for fetch_lock
* si7210: remove otp_lock
* si7210: fetch_measurement: change result type to __be16
* si7210: use guard(mutex) instead of scoped_guard
* si7210: read_raw: use FIELD_GET to get raw temperature value
* si7210: read_raw: return temperature in milli-celsius
* si7210: use regulator for getting the voltage
* si7210: si7210_device_wake: remove unnecessary cast
* si7210: si7210_device_init: use fsleep instead of usleep_range
* si7210: si7210_probe: remove i2c_set_clientdata()
* si7210: minor alignment and formatting fixes

Antoni Pokusinski (2):
dt-bindings: iio: magnetometer: add binding for Si7210
iio: magnetometer: si7210: add driver for Si7210

 .../iio/magnetometer/silabs,si7210.yaml       |  48 ++
 drivers/iio/magnetometer/Kconfig              |  11 +
 drivers/iio/magnetometer/Makefile             |   2 +
 drivers/iio/magnetometer/si7210.c             | 446 ++++++++++++++++++
 4 files changed, 507 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/silabs,si7210.yaml
 create mode 100644 drivers/iio/magnetometer/si7210.c
Signature · 1 line
2.25.1