Skip to content

vfio/igd: VFIOConfigMirrorQuirk for igd mirrored registers

Tomita Moeko qemu-devel 2 versions – Applied

Status from this message: Applied to vfio-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesApplied
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

* Removed 'const Property' change, it was a mistake in rebasing.
* Removed unnecessary initializing config_offset explicitly.
* Separated GGC and BDSM mirror into 2 quirks.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3vfio/pci: declare generic quirks in a new header filehw/vfio/pci-quirks.c hw/vfio/pci-quirks.h+75 -510 replies
2/3vfio/pci: introduce config_offset field in VFIOConfigMirrorQuirkhw/vfio/pci-quirks.c hw/vfio/pci-quirks.h+4 -10 replies
3/3vfio/igd: use VFIOConfigMirrorQuirk for mirrored registershw/vfio/igd.c+31 -940 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlex Williamson
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] vfio/igd: VFIOConfigMirrorQuirk for igd mirrored registers

In commit 1a2623b5c9e7 ("vfio/igd: add macro for declaring mirrored registers"), I introduced a macro to handle mirrored registers in igd bar0. However, using the existing VFIOConfigMirrorQuirk should be a better approach I think after going through the vfio code.

This patch set introduces a new header file, pci-quirks.h, to hold generic quirk declarations, and extends VFIOConfigMirrorQuirk to support offsets in PCI config space. This eliminates the need for the previously introduced macro.

Changelog:
v2:
* Removed 'const Property' change, it was a mistake in rebasing.
* Removed unnecessary initializing config_offset explicitly.
* Separated GGC and BDSM mirror into 2 quirks.

Tomita Moeko (3):
vfio/pci: declare generic quirks in a new header file vfio/pci: introduce config_offset field in VFIOConfigMirrorQuirk vfio/igd: use VFIOConfigMirrorQuirk for mirrored registers

 hw/vfio/igd.c        | 125 +++++++++++--------------------------------
 hw/vfio/pci-quirks.c |  57 +++-----------------
 hw/vfio/pci-quirks.h |  72 +++++++++++++++++++++++++
 3 files changed, 109 insertions(+), 145 deletions(-)
 create mode 100644 hw/vfio/pci-quirks.h
Signature · 1 line
2.45.2