PCI: qcom: Move PERST# GPIO & phy retrieval from controller to PCIe bridge node
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected] change-id 20250101-perst-cb885b5a6129Versions newest first
- v5 Latest2 patches 5 repliesApplied inferred link
- v42 patches 3 repliesSuperseded
- v33 patches 18 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 11 replies | Superseded | |
| v1 | 3 patches | 6 replies | Superseded |
Changes in v5 from the cover letter
- Rebased with pci controller/qcom.
- As part of rebase handled one err condition by adding goto err_port_del
- Link to v4: https://lore.kernel.org/r/[email protected]
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | dt-bindings: PCI: qcom: Move phy & reset gpio's to root portDocumentation/ Documentation/ | +42 | 0 replies | |
| 2/2 | PCI: qcom: Add support for multi-root portdrivers/ | +151 | 4 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Rob Herring (Arm) |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/2] PCI: qcom: Move PERST# GPIO & phy retrieval from controller to PCIe bridge node
The main intention of this series is to move wake# to the root port node. After this series we will come up with a patch which registers for wake IRQ from the pcieport driver. The wake IRQ is needed for the endpoint to wakeup the host from D3cold. The driver change for wake IRQ is posted here[1].
There are many places we agreed to move the wake and perst gpio's and phy etc to the pcie root port node instead of bridge node[2] as the these properties are root port specific and does not belongs to bridge node.
So move the phy, phy-names, wake-gpio's in the root port. There is already reset-gpio defined for PERST# in pci-bus-common.yaml, start using that property instead of perst-gpio.
For backward compatibility, don't remove any existing properties in the bridge node.
There are some other properties like num-lanes, max-link-speed which needs to be moved to the root port nodes, but in this series we are excluding them for now as this requires more changes in dwc layer and can complicate the things.
Once this series gets merged all other platforms also will be updated to use this new way.
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/linux-pci/20241211192014.GA3302752@bhelgaas/
---
Changes in v5:
- Rebased with pci controller/qcom.
- As part of rebase handled one err condition by adding goto err_port_del
- Link to v4: https://lore.kernel.org/r/[email protected]
Changes in v4:
- Removed dts patch as Mani suggested to merge driver and dt-binding
patch in this release and have dts changes in the next release.
- Remove wake property from as this will be addressed in pci-bus-common.yaml (Mani)
- Did couple of nits in the comments, function names code etc (Mani).
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Make old properties as deprecated, update commit message (Dmitry)
- Add helper functions wherever both multiport and legacy methods are used. (Mani)
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Remove phy-names property and change the driver, dtsi accordingly (Rob)
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Krishna Chaitanya Chundru (2):
dt-bindings: PCI: qcom: Move phy & reset gpio's to root port
PCI: qcom: Add support for multi-root port
.../devicetree/bindings/pci/qcom,pcie-common.yaml | 32 +++- .../devicetree/bindings/pci/qcom,pcie-sc7280.yaml | 16 +- drivers/pci/controller/dwc/pcie-qcom.c | 178 +++++++++++++++++---- 3 files changed, 193 insertions(+), 33 deletions(-)
---
base-commit: 7c184aa42a3dc9b2630010fbcb06c701c440f8e3
change-id: 20250702-perst-973129cfc9da
Best regards,
Signature · 1 line
krishnachaitanya-linux <[email protected]>