Skip to content

QOM: container_get() removal

Philippe Mathieu-Daudé qemu-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 11 repliesIn review
  2. v310 patches 3 repliesSuperseded

Changes in v4 from the cover letter

- Implement qdev_create_fake_machine() in single patch (peterx)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8qdev: Implement qdev_create_fake_machine() for user emulationaccel/tcg/tcg-all.c hw/core/meson.build hw/core/qdev-user.c +1 more+39 -13 replies
2/8qdev: Make qdev_get_machine() not use container_get()hw/core/qdev.c+6 -11 reply
3/8qdev: Add machine_get_container()hw/core/qdev.c include/hw/qdev-core.h+21 -01 reply
4/8qdev: Use machine_get_container()hw/core/gpio.c hw/core/qdev.c hw/core/sysbus.c +5 more+12 -151 reply
5/8qom: Add object_get_container()include/qom/object.h qom/object.c+20 -01 reply
6/8qom: Use object_get_container()backends/cryptodev.c chardev/char.c qom/object.c +3 more+8 -81 reply
7/8qom: Remove container_get()include/qom/object.h qom/container.c+0 -341 reply
8/8system: Inline machine_containers[] in qemu_create_machine_containers()system/vl.c+7 -91 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéPeter XuDaniel P. BerrangéRichard Henderson
1/8A-b R-b
2/8R-b R-b
3/8R-b R-b
4/8R-b R-b
5/8R-b R-b R-b
6/8R-b R-b
7/8R-b R-b
8/8A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/8] QOM: container_get() removal

Respin of Peter's v2:
https://lore.kernel.org/qemu-devel/[email protected]/

'The series is about container_get() and its removal.' (See v2's cover).

Since v3:
- Implement qdev_create_fake_machine() in single patch (peterx)

Since v2:
- Create fake machine container for user emulation to avoid:

  $ ./qemu-x86_64 /bin/echo foo
  qemu-x86_64: ../../hw/core/qdev.c:825: qdev_get_machine: Assertion `dev' failed.
  Aborted (core dumped)

Peter Xu (6):
qdev: Make qdev_get_machine() not use container_get()
qdev: Add machine_get_container()
qdev: Use machine_get_container()
qom: Add object_get_container()
qom: Use object_get_container()
qom: Remove container_get()

Philippe Mathieu-Daudé (2):
qdev: Implement qdev_create_fake_machine() for user emulation
system: Inline machine_containers[] in
qemu_create_machine_containers()

 include/hw/qdev-core.h | 20 ++++++++++++++++++++
 include/qom/object.h   | 21 ++++++++++-----------
 accel/tcg/tcg-all.c    |  8 +++++++-
 backends/cryptodev.c   |  4 ++--
 chardev/char.c         |  2 +-
 hw/core/gpio.c         |  3 +--
 hw/core/qdev-user.c    | 21 +++++++++++++++++++++
 hw/core/qdev.c         | 21 ++++++++++++++++++---
 hw/core/sysbus.c       |  4 ++--
 hw/i386/pc.c           |  4 ++--
 qom/container.c        | 23 -----------------------
 qom/object.c           | 12 +++++++++++-
 scsi/pr-manager.c      |  4 ++--
 system/ioport.c        |  2 +-
 system/memory.c        |  2 +-
 system/qdev-monitor.c  |  6 +++---
 system/vl.c            | 19 ++++++++-----------
 ui/console.c           |  2 +-
 ui/dbus-chardev.c      |  2 +-
 hw/core/meson.build    |  1 +
 20 files changed, 113 insertions(+), 68 deletions(-)
 create mode 100644 hw/core/qdev-user.c
Signature · 1 line
2.47.1