semihosting: Reduce target specific code
Status from this message: Queued to semihosting/next, thanks.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | semihosting/syscalls: Include missing 'exec/cpu-defs.h' headerinclude/ | +1 | 0 replies | |
| 2/5 | semihosting/uaccess: Include missing 'exec/cpu-all.h' headersemihosting/ | +1 | 0 replies | |
| 3/5 | semihosting/arm-compat: Include missing 'cpu.h' headersemihosting/ | +1 | 0 replies | |
| 4/5 | semihosting/console: Avoid including 'cpu.h'include/ semihosting/ | +2 | 0 replies | |
| 5/5 | semihosting/meson: Build config.o and console.o oncesemihosting/ | +6 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Richard Henderson |
|---|---|
| Series | R-b |
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] semihosting: Reduce target specific code
This series makes semihosting config.c and console.c target agnostic, building them once, removing symbol collision of the following functions in the single binary:
- qemu_semihosting_chardev_init
- qemu_semihosting_config_options
- qemu_semihosting_config_opts
- qemu_semihosting_enable
- semihosting_arg_fallback
- semihosting_enabled
- semihosting_get_argc
- semihosting_get_target
This function is still problematic, being built for each target:
- qemu_semihosting_guestfd_init
Note, it depends on CONFIG_ARM_COMPATIBLE_SEMIHOSTING which is target specific, so doesn't scale in a heterogeneous setup like the ZynqMP machine, having ARM cores with CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y and MicroBlaze ones with CONFIG_ARM_COMPATIBLE_SEMIHOSTING=n.
I suppose the semihosting API needs rework to consider the CPUClass? I'll let that investigation for the maintainer ;)
Regards,
Phil.
Philippe Mathieu-Daudé (5):
semihosting/syscalls: Include missing 'exec/cpu-defs.h' header semihosting/uaccess: Include missing 'exec/cpu-all.h' header semihosting/arm-compat: Include missing 'cpu.h' header semihosting/console: Avoid including 'cpu.h' semihosting/meson: Build config.o and console.o once
include/semihosting/console.h | 2 -- include/semihosting/syscalls.h | 1 + semihosting/arm-compat-semi.c | 1 + semihosting/console.c | 3 ++- semihosting/uaccess.c | 1 + semihosting/meson.build | 9 ++++++--- 6 files changed, 11 insertions(+), 6 deletions(-)
Signature · 1 line
2.47.1