Skip to content

Fix queue freeze and limit locking order

Damien Le Moal linux-block linux-nvme 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block: Fix sysfs queue freeze and limits lock orderblock/blk-sysfs.c+64 -5911 replies
2/3block: Fix __blk_mq_update_nr_hw_queues() queue freeze and limits lock orderblock/blk-mq.c+16 -93 replies
3/3nvme: Fix queue freeze and limits lock orderdrivers/nvme/host/core.c+5 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Fix queue freeze and limit locking order

Three patches to fix the ordering of freezing a queue with blk_mq_freeze_queue() and obtaining a device queue limits lock with queue_limits_start_update(). These changes ensure that a devie queue is always frozen after the device limits lock is obtained to avoid potential ABBA deadlocks in drivers that need to issue commands to probe a device limits with the limits lock held (e.g. the SCSI sd driver).

Damien Le Moal (3):
block: Fix sysfs queue freeze and limits lock order
block: Fix __blk_mq_update_nr_hw_queues() queue freeze and limits lock
order
nvme: Fix queue freeze and limits lock order

 block/blk-mq.c           |  25 +++++---
 block/blk-sysfs.c        | 123 ++++++++++++++++++++-------------------
 drivers/nvme/host/core.c |   8 ++-
 3 files changed, 85 insertions(+), 71 deletions(-)
Signature · 1 line
2.47.1