Skip to content

Fix encoding overlayfs fid for fanotify delete events

Amir Goldstein linux-fsdevel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ovl: pass realinode to ovl_encode_real_fh() instead of realdentryfs/overlayfs/copy_up.c fs/overlayfs/export.c fs/overlayfs/namei.c +1 more+12 -100 replies
2/2ovl: support encoding fid from inode with no aliasfs/overlayfs/export.c+25 -212 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchDmitry Safonov
1/2
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Fix encoding overlayfs fid for fanotify delete events

Christian,

This is a followup fix to the reported regression [1] that was introduced by overlayfs non-decodable file handles support in v6.6.

The first fix posted two weeks ago [2] was a quick band aid which is justified on its own and is still queued on your vfs.fixes branch.

This followup fix fixes the root cause of overlayfs file handle encoding failure and it also solves a bug with fanotify FAN_DELETE_SELF events on overlayfs, that was discovered from analysis of the first report.

The fix to fanotify delete events was verified with a new LTP test [3].

Thanks,
Amir.

[1] https://lore.kernel.org/linux-fsdevel/CAOQ4uxiie81voLZZi2zXS1BziXZCM24nXqPAxbu8kxXCUWdwOg@mail.gmail.com/
[2] https://lore.kernel.org/linux-fsdevel/[email protected]/
[3] https://github.com/amir73il/ltp/commits/ovl_encode_fid/

Amir Goldstein (2):
ovl: pass realinode to ovl_encode_real_fh() instead of realdentry
ovl: support encoding fid from inode with no alias

 fs/overlayfs/copy_up.c   | 11 +++++----
 fs/overlayfs/export.c    | 49 ++++++++++++++++++++++------------------
 fs/overlayfs/namei.c     |  4 ++--
 fs/overlayfs/overlayfs.h |  2 +-
 4 files changed, 36 insertions(+), 30 deletions(-)
Signature · 1 line
2.34.1