Skip to content

mlx5 HW-Managed Flow Steering in FS core level

Tariq Toukan netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 2 repliesApplied 15/15
  2. v113 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Added two HWS patches to the series
- Added documentation on mlx5.rst
- Added prefix to static functions (Przemek Kitszel)
- Fixed returned error value and copyright year (Przemek Kitszel)
- Added missing braces (Przemek Kitszel)
- Added comma on enum definition (Przemek Kitszel)

Patches in v2 All 15 applied

#Subject and filesSizeRepliesApplied
1/15net/mlx5: fs, add HWS root namespace functionsdrivers/net/ethernet/mellanox/mlx5/core/Makefile drivers/net/ethernet/mellanox/mlx5/core/fs_core.h drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c +1 more+90 -40 repliesApplied
2/15net/mlx5: fs, add HWS flow table API functionsdrivers/net/ethernet/mellanox/mlx5/core/fs_core.h drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.h+122 -10 repliesApplied
3/15net/mlx5: fs, add HWS flow group API functionsdrivers/net/ethernet/mellanox/mlx5/core/fs_core.h drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.h+50 -10 repliesApplied
4/15net/mlx5: fs, add HWS actions pooldrivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.h+67 -00 repliesApplied
5/15net/mlx5: fs, add HWS packet reformat API functiondrivers/net/ethernet/mellanox/mlx5/core/Makefile drivers/net/ethernet/mellanox/mlx5/core/fs_core.h drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c +7 more+598 -110 repliesApplied
6/15net/mlx5: fs, add HWS modify header API functiondrivers/net/ethernet/mellanox/mlx5/core/fs_core.h drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.h +2 more+310 -00 repliesApplied
7/15net/mlx5: fs, manage flow counters HWS action sharing by refcountdrivers/net/ethernet/mellanox/mlx5/core/fs_core.h drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws_pools.c +1 more+94 -290 repliesApplied
8/15net/mlx5: fs, add dest table cachedrivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.h+66 -30 repliesApplied
9/15net/mlx5: fs, add HWS fte API functionsdrivers/net/ethernet/mellanox/mlx5/core/fs_core.h drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.h+566 -11 replyApplied
10/15net/mlx5: fs, add support for dest vport HWS actiondrivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.h+65 -00 repliesApplied
11/15net/mlx5: fs, set create match definer to not supported by HWSdrivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c+14 -00 repliesApplied
12/15net/mlx5: fs, add HWS get capabilitiesdrivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c+12 -00 repliesApplied
13/15net/mlx5: fs, add HWS to steering mode optionsDocumentation/networking/devlink/mlx5.rst drivers/net/ethernet/mellanox/mlx5/core/fs_core.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c +1 more+49 -160 repliesApplied
14/15net/mlx5: HWS, update flow - remove the use of dual RTCsdrivers/net/ethernet/mellanox/mlx5/core/steering/hws/debug.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/internal.h drivers/net/ethernet/mellanox/mlx5/core/steering/hws/matcher.c +3 more+81 -1841 replyApplied
15/15net/mlx5: HWS, update flow - support through bigger action RTCdrivers/net/ethernet/mellanox/mlx5/core/steering/hws/matcher.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/rule.c drivers/net/ethernet/mellanox/mlx5/core/steering/hws/rule.h +1 more+80 -530 repliesApplied

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchYevgeny KliteynikMark Bloch
1/15R-b R-b
2/15R-b R-b
3/15R-b R-b
4/15R-b R-b
5/15R-b R-b
6/15R-b R-b
7/15R-b R-b
8/15R-b R-b
9/15R-b R-b
10/15R-b R-b
11/15R-b R-b
12/15R-b R-b
13/15R-b R-b
14/15R-b
15/15R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next V2 00/15] mlx5 HW-Managed Flow Steering in FS core level

Hi,

This patchset by Moshe follows Yevgeny's patchsets [1][2] on subject "HW-Managed Flow Steering in mlx5 driver". As introduced there in HW managed Flow Steering mode (HWS) the driver is configuring steering rules directly to the HW using WQs with a special new type of WQE (Work Queue Element). This way we can reach higher rule insertion/deletion rate with much lower CPU utilization compared to SW Managed Flow Steering (SWS).

This patchset adds API to manage namespace, flow tables, flow groups and prepare FTE (Flow Table Entry) rules. It also adds caching and pool mechanisms for HWS actions to allow sharing of steering actions among different rules. The implementation of this API in FS layer, allows FS core to use HW Managed Flow Steering in addition to the existing FW or SW Managed Flow Steering.

Patch 13 of this series adds support for configuring HW Managed Flow Steering mode through devlink param, similar to configuring SW Managed Flow Steering mode:

 # devlink dev param set pci/0000:08:00.0 name flow_steering_mode \
      cmode runtime value hmfs

In addition, the series contains 2 HWS patches from Yevgeny that implement flow update support.

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/

Regards,
Tariq

V2:
- Added two HWS patches to the series
- Added documentation on mlx5.rst
- Added prefix to static functions (Przemek Kitszel)
- Fixed returned error value and copyright year (Przemek Kitszel)
- Added missing braces (Przemek Kitszel)
- Added comma on enum definition (Przemek Kitszel)

Moshe Shemesh (13):
net/mlx5: fs, add HWS root namespace functions net/mlx5: fs, add HWS flow table API functions net/mlx5: fs, add HWS flow group API functions net/mlx5: fs, add HWS actions pool
net/mlx5: fs, add HWS packet reformat API function net/mlx5: fs, add HWS modify header API function net/mlx5: fs, manage flow counters HWS action sharing by refcount net/mlx5: fs, add dest table cache
net/mlx5: fs, add HWS fte API functions
net/mlx5: fs, add support for dest vport HWS action net/mlx5: fs, set create match definer to not supported by HWS net/mlx5: fs, add HWS get capabilities
net/mlx5: fs, add HWS to steering mode options

Yevgeny Kliteynik (2):
net/mlx5: HWS, update flow - remove the use of dual RTCs net/mlx5: HWS, update flow - support through bigger action RTC

 Documentation/networking/devlink/mlx5.rst     |    3 +
 .../net/ethernet/mellanox/mlx5/core/Makefile  |    5 +-
 .../net/ethernet/mellanox/mlx5/core/fs_core.c |   50 +-
 .../net/ethernet/mellanox/mlx5/core/fs_core.h |   62 +-
 .../ethernet/mellanox/mlx5/core/fs_counters.c |   42 +-
 .../net/ethernet/mellanox/mlx5/core/fs_pool.c |    5 +-
 .../net/ethernet/mellanox/mlx5/core/fs_pool.h |    5 +-
 .../mellanox/mlx5/core/steering/hws/debug.c   |   10 +-
 .../mellanox/mlx5/core/steering/hws/fs_hws.c  | 1377 +++++++++++++++++
 .../mellanox/mlx5/core/steering/hws/fs_hws.h  |   80 +
 .../mlx5/core/steering/hws/fs_hws_pools.c     |  450 ++++++
 .../mlx5/core/steering/hws/fs_hws_pools.h     |   73 +
 .../mlx5/core/steering/hws/internal.h         |    1 -
 .../mellanox/mlx5/core/steering/hws/matcher.c |  180 +--
 .../mellanox/mlx5/core/steering/hws/matcher.h |    8 +-
 .../mellanox/mlx5/core/steering/hws/rule.c    |  141 +-
 .../mellanox/mlx5/core/steering/hws/rule.h    |   16 +-
 .../mellanox/mlx5/core/steering/hws/send.c    |   20 +-
 include/linux/mlx5/mlx5_ifc.h                 |    1 +
 19 files changed, 2245 insertions(+), 284 deletions(-)
 create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
 create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.h
 create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws_pools.c
 create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws_pools.h

base-commit: a3b3d2dc389568a77d0e25da17203e3616218e93

Signature · 1 line
2.45.0