Skip to content

migration: Fix s390 regressions + migration script

Fabiano Rosas qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 14 repliesIn review
  2. v27 patches 6 repliesSuperseded
  3. v17 patches 10 repliesSuperseded

changes from the cover letter

- fixed appending again
- changed the VMSDFieldNull class to inherit from VMSDFieldGeneric

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7migration: Add more error handling to analyze-migration.pyscripts/analyze-migration.py+45 -300 replies
2/7migration: Remove unused argument in vmsd_desc_field_endmigration/vmstate.c+2 -20 replies
3/7migration: Fix parsing of s390 streamscripts/analyze-migration.py+17 -19 replies
4/7migration: Rename vmstate_info_nullptrmigration/vmstate-types.c scripts/analyze-migration.py+24 -11 reply
5/7migration: Dump correct JSON format for nullptr replacementmigration/vmstate.c+91 -270 replies
6/7migration: Fix arrays of pointers in JSON writermigration/vmstate.c scripts/analyze-migration.py+50 -91 reply
7/7s390x: Fix CSS migrationhw/s390x/s390-virtio-ccw.c+1 -13 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchPeter XuThomas Huth
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] migration: Fix s390 regressions + migration script

changes:

- fixed appending again
- changed the VMSDFieldNull class to inherit from VMSDFieldGeneric

v2:
https://lore.kernel.org/r/[email protected]

- dropped comments patch
- new patch 4: rename the field to nullptr
- patch 6: add a sample JSON, fix the appending code

v1:
https://lore.kernel.org/r/[email protected]

Hi,

The situation that broke the last migration PR was:

1) emitting of JSON data by QEMU for VMSTATE_ARRAY_OF_POINTER_TO_STRUCT when NULL pointers are present has been broken for a while;

2) parsing of s390x migration stream by analyze-script.py has been broken for a while;

(there's indications that it worked on s390x hosts, I'm assuming due to byte order coincidences)

3) s390x CSS migration has been broken for a while;

The s390x CSS migration uses VMSTATE_ARRAY_OF_POINTER_TO_STRUCT with NULL pointers, triggering #1, but hidden due to #2 on TCG hosts and due to #3 overall.

- patches 1: just to make rebase easier
- patches 2-3: cleanups
- patch 4: fixes #2
- patches 5-6: fix #1
- patch 7: fixes #3

Fabiano Rosas (6):
migration: Add more error handling to analyze-migration.py
migration: Remove unused argument in vmsd_desc_field_end
migration: Fix parsing of s390 stream
migration: Rename vmstate_info_nullptr
migration: Fix arrays of pointers in JSON writer
s390x: Fix CSS migration

Peter Xu (1):
migration: Dump correct JSON format for nullptr replacement

 hw/s390x/s390-virtio-ccw.c   |   2 +-
 migration/vmstate-types.c    |   2 +-
 migration/vmstate.c          | 151 ++++++++++++++++++++++++++++-------
 scripts/analyze-migration.py | 142 +++++++++++++++++++++++---------
 4 files changed, 228 insertions(+), 69 deletions(-)
Signature · 1 line
2.35.3