i.MX and SDHCI improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest13 patches 16 repliesIn review
- v114 patches 21 repliesSuperseded
Changes in v2 from the cover letter
* Drop redundant implementation of TYPE_OR_IRQ (David, Zoltan)
* Use absolute QOM paths when tracing in imx_gpio and imx_i2c (Phil)
* Trace hexadecimal values in imx_serial (Phil)
* Do NOT move inversion of presence and write-protect GPIOs since that changes the internal logic of the device
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriatehw/ | +8 | 3 replies | |
| 2/13 | hw/char/imx_serial: Fix reset value of UFCR registerhw/ include/ | +2 | 1 reply | |
| 3/13 | hw/char/imx_serial: Update all state before restarting ageing timerhw/ | +3 | 1 reply | |
| 4/13 | hw/pci-host/designware: Expose MSI IRQhw/ hw/ hw/ +4 more | +36 | 1 reply | |
| 5/13 | hw/gpio/imx_gpio: Don't clear input GPIO values upon resethw/ | +0 | 1 reply | |
| 6/13 | hw/sd/sd: Remove legacy sd_set_cb() in favor of GPIOshw/ include/ | +14 | 4 replies | |
| 7/13 | hw/sd/sd: Allow for inverting polarities of presence and write-protect GPIOshw/ | +8 | 2 replies | |
| 8/13 | hw/char/imx_serial: Turn some DPRINTF() statements into trace eventshw/ hw/ | +44 | 0 replies | |
| 9/13 | hw/timer/imx_gpt: Remove unused definehw/ | +0 | 0 replies | |
| 10/13 | tests/qtest/libqos: Reuse TYPE_IMX_I2C definetests/ tests/ | +5 | 0 replies | |
| 11/13 | hw/i2c/imx_i2c: Convert DPRINTF() to trace eventshw/ hw/ | +10 | 1 reply | |
| 12/13 | hw/misc/imx6_src: Convert DPRINTF() to trace eventshw/ hw/ | +11 | 0 replies | |
| 13/13 | hw/gpio/imx_gpio: Turn DPRINTF() into trace eventshw/ hw/ | +12 | 0 replies |
Reviews trailers per patch
11 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Fabiano Rosas | Corey Minyard | Peter Maydell |
|---|---|---|---|---|
| 1/13 | R-b | |||
| 2/13 | R-b | |||
| 3/13 | R-b | |||
| 4/13 | R-b | |||
| 5/13 | ||||
| 6/13 | R-b | |||
| 7/13 | ||||
| 8/13 | R-b T-b | |||
| 9/13 | R-b | |||
| 10/13 | R-b T-b | R-b | ||
| 11/13 | R-b T-b | A-b | ||
| 12/13 | R-b T-b | |||
| 13/13 | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 00/13] i.MX and SDHCI improvements
This series fixes some details in i.MX platform devices, improves SDHCI compatibility with U-Boot and modernizes some code.
The first 5 patches are bugfixes 1/ resolving infinite loop in U-Boot esdhc driver, 2/ fixing a character echoing issue in imx-serial, 3/ fixing IRQ sharing issue in Designware PCIe emulation, and 4/ fixing GPIO level preservation across resets in imx-gpio.
Patches 6 and 7 modernize SD card emulation by turning presence and write-protect GPIOs into qdev GPIOs and then further allowing the GPIOs to be inverted, just like device tree allows.
The rest of the series is cosmetics including turning DPRINTF() into trace events which eases debugging.
v2:
* Drop redundant implementation of TYPE_OR_IRQ (David, Zoltan)
* Use absolute QOM paths when tracing in imx_gpio and imx_i2c (Phil)
* Trace hexadecimal values in imx_serial (Phil)
* Do NOT move inversion of presence and write-protect GPIOs since that changes the internal logic of the device
Bernhard Beschow (13):
hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate hw/char/imx_serial: Fix reset value of UFCR register hw/char/imx_serial: Update all state before restarting ageing timer hw/pci-host/designware: Expose MSI IRQ
hw/gpio/imx_gpio: Don't clear input GPIO values upon reset hw/sd/sd: Remove legacy sd_set_cb() in favor of GPIOs hw/sd/sd: Allow for inverting polarities of presence and write-protect
GPIOs
hw/char/imx_serial: Turn some DPRINTF() statements into trace events hw/timer/imx_gpt: Remove unused define
tests/qtest/libqos: Reuse TYPE_IMX_I2C define hw/i2c/imx_i2c: Convert DPRINTF() to trace events hw/misc/imx6_src: Convert DPRINTF() to trace events hw/gpio/imx_gpio: Turn DPRINTF() into trace events
include/hw/arm/fsl-imx6.h | 4 +- include/hw/arm/fsl-imx7.h | 4 +- include/hw/char/imx_serial.h | 2 +- include/hw/pci-host/designware.h | 1 + include/hw/sd/sdcard_legacy.h | 1 - hw/arm/fsl-imx6.c | 13 ++++- hw/arm/fsl-imx7.c | 13 ++++- hw/char/imx_serial.c | 65 ++++++++++++++-------- hw/gpio/imx_gpio.c | 19 +++---- hw/i2c/imx_i2c.c | 21 ++----- hw/misc/imx6_src.c | 23 ++------ hw/pci-host/designware.c | 7 +-- hw/sd/sd.c | 39 ++++++------- hw/sd/sdhci.c | 11 +++- hw/timer/imx_gpt.c | 4 -- tests/qtest/libqos/arm-imx25-pdk-machine.c | 5 +- tests/qtest/libqos/i2c-imx.c | 4 +- hw/arm/Kconfig | 2 + hw/char/trace-events | 5 ++ hw/gpio/trace-events | 5 ++ hw/i2c/trace-events | 5 ++ hw/misc/trace-events | 6 ++ 22 files changed, 151 insertions(+), 108 deletions(-)
Signature · 1 line
2.48.0