Skip to content

usb: xhci: page size improvements

Niklas Neronin linux-usb 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 0 repliesNew
  2. v32 patches 2 repliesSuperseded
  3. v22 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches3 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: xhci: correct debug message page size calculationdrivers/usb/host/xhci-mem.c+3 -30 replies
2/2usb: xhci: set page size to the xHCI-supported sizedrivers/usb/host/xhci-mem.c drivers/usb/host/xhci.h+22 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] usb: xhci: page size improvements

Correct off-by-one page size debug message.
Set page size to the xHCI-supported size, instead of 4KB.

Clarified the interpretation of the xHCI spec 1.9 regarding page size. The correct interpretation is that only one bit is set, indicating the only supported page size. This is supported by the following sources:

Section 6.6.1, PSZ:
The PSZ calculation uses the page size bit and would not work with multiple bits set.

Section 7.7, Implementation Notes:
"This version of the xHCI spec only allows an implementation to support
a single page size, as reported by the PAGESIZE register."

Version 4 changes:
* Replace manual power of 2 check with is_power_of_2()
Version 3 changes:
* Rebase agains Linux 6.14-rc1.
* Repalce variable int 'i' with unsigned int 'val'.
* Rename temp variable 'page_shift' to 'page_size'.
Version 2 changes:
* Added handling for invalid page size register values.

Niklas Neronin (2):
usb: xhci: correct debug message page size calculation
usb: xhci: set page size to the xHCI-supported size

 drivers/usb/host/xhci-mem.c | 34 ++++++++++++++++++----------------
 drivers/usb/host/xhci.h     |  8 ++++----
 2 files changed, 22 insertions(+), 20 deletions(-)
Signature · 1 line
2.47.2