Skip to content

NFS & SUNRPC: Sysfs Improvements

Anna Schumaker linux-nfs 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesNew
  2. v25 patches 2 repliesSuperseded
  3. v13 patches 8 repliesSuperseded

Changes in v3 from the cover letter

* Fix up the mode bits for the max_connect file
* Replace call to xprt_iter_get_xprt() with xprt_iter_get_next()

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5NFS: Add implid to sysfsfs/nfs/sysfs.c+60 -00 replies
2/5sunrpc: Add a sysfs attr for xprtsecnet/sunrpc/sysfs.c+29 -00 replies
3/5sunrpc: Add a sysfs files for rpc_clnt informationnet/sunrpc/sysfs.c+73 -00 replies
4/5sunrpc: Add a sysfs file for adding a new xprtinclude/linux/sunrpc/xprtmultipath.h net/sunrpc/sysfs.c net/sunrpc/xprtmultipath.c+76 -00 replies
5/5sunrpc: Add a sysfs file for one-step xprt deletionnet/sunrpc/sysfs.c+46 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchBenjamin Coddington
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] NFS & SUNRPC: Sysfs Improvements

From: Anna Schumaker <[email protected]>

These are a handful of improvements that have been in the back of my mind for a while. The first patch adds a (read-only) file to the NFS client's sysfs collection to check the server's implementation id. The remaining patches are on the sunrpc side.

I did look into the 'nconnect' and 'max_connect' NFS client mount options and how they interact with adding a new xprt in patch 4. My reading is that 'nconnect' is just the initial number of connections made by the NFS client during mounting. That shouldn't disallow adding a new connection. The 'max_connect' parameter refers to the maximum number of unique IP addresses in an xprt switch. The new connection I generate is a clone of the main xprt, not a new address, so this doesn't come into play either. So I'm convinced adding a new xprt is okay to do here.

Changes in v3:
* Fix up the mode bits for the max_connect file
* Replace call to xprt_iter_get_xprt() with xprt_iter_get_next()

Thoughts?
Anna

Anna Schumaker (5):
NFS: Add implid to sysfs
sunrpc: Add a sysfs attr for xprtsec
sunrpc: Add a sysfs files for rpc_clnt information
sunrpc: Add a sysfs file for adding a new xprt
sunrpc: Add a sysfs file for one-step xprt deletion

 fs/nfs/sysfs.c                       |  60 ++++++++
 include/linux/sunrpc/xprtmultipath.h |   1 +
 net/sunrpc/sysfs.c                   | 202 +++++++++++++++++++++++++++
 net/sunrpc/xprtmultipath.c           |  21 +++
 4 files changed, 284 insertions(+)
Signature · 1 line
2.48.1