Skip to content

Panel Replay mode change without full modeset

Jouni Högander intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915/psr: Add new function for writing sink panel replay enable bitdrivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/display/intel_psr.h+8 -01 reply
2/4drm/i915/psr: Enable Panel Replay on sink always when it's supporteddrivers/gpu/drm/i915/display/intel_ddi.c+1 -21 reply
3/4drm/i915/psr: Make intel_psr_enable_sink as local static functiondrivers/gpu/drm/i915/display/intel_psr.c drivers/gpu/drm/i915/display/intel_psr.h+2 -41 reply
4/4drm/i915/psr: Allow changing Panel Replay mode without full modesetdrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_psr.c+17 -222 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMika Kahola
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Panel Replay mode change without full modeset

This patch set allows changing Panel Replay mode without full modeset. There are couple of requirements in eDP1.5/DP2.0 spec:

"Enabling of the PR function shall occur prior to link training. To re-enable the PR function after the PR function is disabled, it is necessary to repeat link training."

This is achieved by enabling Panel Replay before link training always if Panel Replay is supported by both sink and source. Panel Replay enable bit is never cleared on sink side. When we are disabling Panel Replay we are just disabling it on source side. This triggers sending "VSC SDP" with "PR_STATE" set as "0 = PR Inactive (normal operation mode, Live Frame mode)"

"The Source device may enable Selective Update by setting DPCD 001B0h[6] = 1 prior to transmitting a VSC SDP with the PR Active state indication (DB1[0] = 1). The Source device that enables PR SU with ALPM shall enable SU Region Early Transport by setting DPCD 001B0h[7] = 1 prior to transmitting a VSC SDP with DB1[0] = 1."

These are achieved by transiting to Panel Replay Inactive state before changing Selective Update or Early Transport bits.

Jouni Högander (4):
drm/i915/psr: Add new function for writing sink panel replay enable
bit
drm/i915/psr: Enable Panel Replay on sink always when it's supported drm/i915/psr: Make intel_psr_enable_sink as local static function drm/i915/psr: Allow changing Panel Replay mode without full modeset

 drivers/gpu/drm/i915/display/intel_ddi.c     |  3 +-
 drivers/gpu/drm/i915/display/intel_display.c | 14 --------
 drivers/gpu/drm/i915/display/intel_psr.c     | 36 ++++++++++++++------
 drivers/gpu/drm/i915/display/intel_psr.h     |  3 +-
 4 files changed, 28 insertions(+), 28 deletions(-)
Signature · 1 line
2.34.1