Skip to content

RFC PRU-ICSSM Ethernet Driver

Basharath Hussain Khaja linux-arm-kernel linux-devicetree linux-omap lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest10 patches 19 repliesIn review
  2. v1 RFC10 patches 25 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCsDocumentation/devicetree/bindings/net/ti,icss-iep.yaml Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml Documentation/devicetree/bindings/net/ti,pruss-ecap.yaml +1 more+193 -05 replies
2/10net: ti: prueth: Adds ICSSM Ethernet driverdrivers/net/ethernet/ti/Kconfig drivers/net/ethernet/ti/Makefile drivers/net/ethernet/ti/icssm/icssm_prueth.c +1 more+639 -02 replies
3/10net: ti: prueth: Adds PRUETH HW and SW configurationdrivers/net/ethernet/ti/icssm/icssm_prueth.c drivers/net/ethernet/ti/icssm/icssm_prueth.h drivers/net/ethernet/ti/icssm/icssm_switch.h+773 -22 replies
4/10net: ti: prueth: Adds link detection, RX and TX support.drivers/net/ethernet/ti/icssm/icssm_prueth.c drivers/net/ethernet/ti/icssm/icssm_prueth.h+640 -54 replies
4/10net: ti: prueth: Adds link detection, RX and TX support.drivers/net/ethernet/ti/icssm/icssm_prueth.c drivers/net/ethernet/ti/icssm/icssm_prueth.h+640 -52 replies
5/10net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driverdrivers/net/ethernet/ti/Makefile drivers/net/ethernet/ti/icssm/icssm_ethtool.c drivers/net/ethernet/ti/icssm/icssm_prueth.c +1 more+362 -12 replies
6/10net: ti: prueth: Adds HW timestamping support for PTP using PRU-ICSS IEP moduledrivers/net/ethernet/ti/icssg/icss_iep.c drivers/net/ethernet/ti/icssm/icssm_ethtool.c drivers/net/ethernet/ti/icssm/icssm_prueth.c +2 more+602 -22 replies
7/10net: ti: prueth: Adds support for network filters for traffic control supported by PRU-ICSSdrivers/net/ethernet/ti/Makefile drivers/net/ethernet/ti/icssm/icssm_ethtool.c drivers/net/ethernet/ti/icssm/icssm_prueth.c +4 more+747 -30 replies
8/10net: ti: prueth: Adds support for RX interrupt coalescing/pacingdrivers/net/ethernet/ti/Kconfig drivers/net/ethernet/ti/Makefile drivers/net/ethernet/ti/icssm/icssm_ethtool.c +5 more+461 -10 replies
9/10net: ti: prueth: Adds power management support for PRU-ICSSdrivers/net/ethernet/ti/icssm/icssm_prueth.c+62 -00 replies
10/10arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP modules of PRU-ICSS2 Instance.arch/arm/boot/dts/ti/omap/am57-pruss.dtsi arch/arm/boot/dts/ti/omap/am571x-idk.dts arch/arm/boot/dts/ti/omap/am572x-idk.dts +2 more+91 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC v2 PATCH 00/10] PRU-ICSSM Ethernet Driver

Hi,

The Programmable Real-Time Unit Industrial Communication Sub-system (PRU-ICSS) is available on the TI SOCs in two flavors: Gigabit ICSS (ICSSG) and the older Megabit ICSS (ICSSM).

Support for ICSSG Dual-EMAC mode has already been mainlined [1] and the fundamental components/drivers such as PRUSS driver, Remoteproc driver, PRU-ICSS INTC, and PRU-ICSS IEP drivers are already available in the mainline Linux kernel. The current RFC patch series builds on top of these components and introduces changes to support the Dual-EMAC mode on ICSSM, especially on the TI AM57xx devices.

TI AM57xx series of devices have two identical PRU-ICSS instances (PRU-ICSS1 and PRU-ICSS2), each with two 32-bit RISC PRU cores. Each PRU core has
(a) dedicated Ethernet interface (MII, MDIO), timers, capture modules, and serial communication interfaces, and (b) dedicated data and instruction RAM as well as shared RAM for inter PRU communication within the PRU-ICSS.

This set of patches is a follow-up to [2] yet to merged. These patches add support for the following features::
- RX and TX over PRU Ethernet ports in Dual-EMAC mode
- Full duplex with 100 Mbps link speed.
- VLAN Filtering
- Multicast Filtering
- Promiscuous mode
- Storm prevention
- Interrupt coalescing
- Linux PTP (ptp4l) Ordinary clock

Further, note that these are the first set of patches for PRU-ICSS2 Ethernet. Switch mode support, PRU-ICSS1 support, PRU Ethernet for AM437x and AM335x in Dual-EMAC and Switch mode support with full feature set changes will be posted subsequently.

These changes are validated on top of Linux next kernel by reverting a recent commit [3]. This commit is breaking the Ethernet functionality on TI AM57xx due to zero block size allocation in SRAM during initialization.

The patches presented in this series have gone through the patch verification tools and no warnings or errors are reported. Sample test logs verifying the functionality on Linux next kernel are available here:

[Interface up Testing](https://gist.github.com/basharath-cit/7fbdd48dec77e3eb3afee0eac4b5bc14)

[Ping Testing](https://gist.github.com/basharath-cit/edd75dedf0a69888ad8f1211540380b8)

[Iperf Testing](https://gist.github.com/basharath-cit/8e20dfdfbae5d14ccbbc5b76d8b90e73)

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.13-rc5&id=1a52a094c2f0821860d9ce15fffe01103a146f1f

This is the v2 of the patch series [v1]. This version of the patchset addresses the comments made on [v1] of the series.

Changes from v1 to v2 :

*) Addressed Andrew Lunn, Rob Herring comments on patch 1 of the series. *) Addressed Andrew Lunn comments on patch 2, 3, and 4 of the series. *) Addressed Richard Cochran, Jason Xing comments on patch 6 of the series. *) Rebased patchset on next-202401xx linux-next.

[v1] https://lore.kernel.org/all/[email protected]/

Thanks & Best Regards,
Basharath

Murali Karicheri (1):
net: ti: prueth: Adds support for RX interrupt coalescing/pacing

Parvathi Pudi (1):
dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for
AM57xx SOCs

Roger Quadros (8):
net: ti: prueth: Adds ICSSM Ethernet driver
net: ti: prueth: Adds PRUETH HW and SW configuration
net: ti: prueth: Adds link detection, RX and TX support.
net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver
net: ti: prueth: Adds HW timestamping support for PTP using PRU-ICSS
IEP module
net: ti: prueth: Adds support for network filters for traffic control
supported by PRU-ICSS
net: ti: prueth: Adds power management support for PRU-ICSS
arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP
modules of PRU-ICSS2 Instance.

 .../devicetree/bindings/net/ti,icss-iep.yaml  |    5 +
 .../bindings/net/ti,icssm-prueth.yaml         |  147 +
 .../bindings/net/ti,pruss-ecap.yaml           |   32 +
 .../devicetree/bindings/soc/ti/ti,pruss.yaml  |    9 +
 arch/arm/boot/dts/ti/omap/am57-pruss.dtsi     |   11 +
 arch/arm/boot/dts/ti/omap/am571x-idk.dts      |    8 +-
 arch/arm/boot/dts/ti/omap/am572x-idk.dts      |   10 +-
 arch/arm/boot/dts/ti/omap/am574x-idk.dts      |   10 +-
 .../boot/dts/ti/omap/am57xx-idk-common.dtsi   |   61 +
 drivers/net/ethernet/ti/Kconfig               |   24 +
 drivers/net/ethernet/ti/Makefile              |    5 +
 drivers/net/ethernet/ti/icssg/icss_iep.c      |   42 +
 drivers/net/ethernet/ti/icssm/icssm_ethtool.c |  303 +++
 drivers/net/ethernet/ti/icssm/icssm_prueth.c  | 2396 +++++++++++++++++
 drivers/net/ethernet/ti/icssm/icssm_prueth.h  |  428 +++
 .../net/ethernet/ti/icssm/icssm_prueth_dos.c  |  225 ++
 .../net/ethernet/ti/icssm/icssm_prueth_ecap.c |  312 +++
 .../net/ethernet/ti/icssm/icssm_prueth_ecap.h |   47 +
 .../net/ethernet/ti/icssm/icssm_prueth_ptp.h  |   85 +
 drivers/net/ethernet/ti/icssm/icssm_switch.h  |  285 ++
 .../ti/icssm/icssm_vlan_mcast_filter_mmap.h   |  120 +
 21 files changed, 4556 insertions(+), 9 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml
 create mode 100644 Documentation/devicetree/bindings/net/ti,pruss-ecap.yaml
 create mode 100644 drivers/net/ethernet/ti/icssm/icssm_ethtool.c
 create mode 100644 drivers/net/ethernet/ti/icssm/icssm_prueth.c
 create mode 100644 drivers/net/ethernet/ti/icssm/icssm_prueth.h
 create mode 100644 drivers/net/ethernet/ti/icssm/icssm_prueth_dos.c
 create mode 100644 drivers/net/ethernet/ti/icssm/icssm_prueth_ecap.c
 create mode 100644 drivers/net/ethernet/ti/icssm/icssm_prueth_ecap.h
 create mode 100644 drivers/net/ethernet/ti/icssm/icssm_prueth_ptp.h
 create mode 100644 drivers/net/ethernet/ti/icssm/icssm_switch.h
 create mode 100644 drivers/net/ethernet/ti/icssm/icssm_vlan_mcast_filter_mmap.h
Signature · 1 line
2.34.1