Skip to content

drm/meson: vclk: revert and re-fix vclk calculations

Christian Hewitt dri-devel linux-amlogic linux-arm-kernel lkml oe-kbuild-all stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Revert "drm/meson: vclk: fix calculation of 59.94 fractional rates"drivers/gpu/drm/meson/meson_vclk.c+3 -31 reply
2/2drm/meson: vclk: fix precision in vclk calculationsdrivers/gpu/drm/meson/meson_encoder_hdmi.c drivers/gpu/drm/meson/meson_vclk.c+23 -224 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNeil Armstrong
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] drm/meson: vclk: revert and re-fix vclk calculations

Patch 1 reverts a previous fix for loss of HDMI sync when playing YUV420 @ 59.94 media. The patch does resolve a calculation issue. It also makes all fractional rates invalid which is a bigger problem.

Patch 2 provides a proper fix after I figured out the actual root cause of the original problem. This time the maths checks out.

Apologies to the stable team as the original patch has been applied to a wide range of older and LTS kernels (as far as 5.10). Please let me know if combining the two patches into a single 'fix the previous fix' patch would be preferred?

Christian

Christian Hewitt (2):
Revert "drm/meson: vclk: fix calculation of 59.94 fractional rates" drm/meson: vclk: fix precision in vclk calculations

 drivers/gpu/drm/meson/meson_encoder_hdmi.c | 42 +++++++++++-----------
 drivers/gpu/drm/meson/meson_vclk.c         |  7 ++--
 2 files changed, 25 insertions(+), 24 deletions(-)
Signature · 1 line
2.34.1