Skip to content

af_unix: Set skb drop reason in every kfree_skb() path.

Kuniyuki Iwashima netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 0 repliesApplied 9/9
  2. v211 patches 6 repliesSuperseded
  3. v112 patches 4 repliesSuperseded

Changes in v3 from the cover letter

* Drop skb drop reason patches for connect() and sendmsg()
* Restore patch 8
* Add patch 9 replacing kfree_skb() with consume_skb() in connect() and sendmsg()

Patches in v3 All 9 applied

#Subject and filesSizeRepliesApplied
1/9net: dropreason: Gather SOCKET_ drop reasons.include/net/dropreason-core.h+6 -60 repliesApplied
2/9af_unix: Set drop reason in unix_release_sock().include/net/dropreason-core.h net/unix/af_unix.c+5 -20 repliesApplied
3/9af_unix: Set drop reason in unix_sock_destructor().net/unix/af_unix.c+1 -10 repliesApplied
4/9af_unix: Set drop reason in __unix_gc().net/unix/garbage.c+1 -10 repliesApplied
5/9af_unix: Set drop reason in manage_oob().include/net/dropreason-core.h net/unix/af_unix.c+7 -10 repliesApplied
6/9af_unix: Set drop reason in unix_stream_read_skb().net/unix/af_unix.c+2 -20 repliesApplied
7/9af_unix: Set drop reason in unix_dgram_disconnected().include/net/dropreason-core.h net/unix/af_unix.c+10 -10 repliesApplied
8/9af_unix: Reuse out_pipe label in unix_stream_sendmsg().net/unix/af_unix.c+9 -140 repliesApplied
9/9af_unix: Use consume_skb() in connect() and sendmsg().net/unix/af_unix.c+14 -140 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 net-next 0/9] af_unix: Set skb drop reason in every kfree_skb() path.

There is a potential user for skb drop reason for AF_UNIX.

This series replaces some kfree_skb() in connect() and sendmsg() paths and sets skb drop reason for the rest of kfree_skb() in AF_UNIX.

Changes:
v3:
* Drop skb drop reason patches for connect() and sendmsg()
* Restore patch 8
* Add patch 9 replacing kfree_skb() with consume_skb() in connect() and sendmsg()

v2: https://lore.kernel.org/netdev/[email protected]/
* Drop the old patch 6 to silence false-positive uninit warning

v1: https://lore.kernel.org/netdev/[email protected]/

Kuniyuki Iwashima (9):
net: dropreason: Gather SOCKET_ drop reasons.
af_unix: Set drop reason in unix_release_sock().
af_unix: Set drop reason in unix_sock_destructor().
af_unix: Set drop reason in __unix_gc().
af_unix: Set drop reason in manage_oob().
af_unix: Set drop reason in unix_stream_read_skb().
af_unix: Set drop reason in unix_dgram_disconnected().
af_unix: Reuse out_pipe label in unix_stream_sendmsg().
af_unix: Use consume_skb() in connect() and sendmsg().

 include/net/dropreason-core.h | 28 +++++++++++----
 net/unix/af_unix.c            | 67 +++++++++++++++++------------------
 net/unix/garbage.c            |  2 +-
 3 files changed, 55 insertions(+), 42 deletions(-)
Signature · 1 line
2.39.5 (Apple Git-154)