Skip to content

tcp: add a new PAWS_ACK drop reason

Eric Dumazet netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesApplied 3/3
  2. v12 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- Also add matching LINUX_MIB_PAWS_OLD_ACK SNMP counter.
- fix a typo in one changelog.

Patches in v2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3tcp: add drop_reason support to tcp_disordered_ack()net/ipv4/tcp_input.c+44 -350 repliesApplied
2/3tcp: add TCP_RFC7323_PAWS_ACK drop reasoninclude/net/dropreason-core.h net/ipv4/tcp_input.c+14 -11 replyApplied
3/3tcp: add LINUX_MIB_PAWS_OLD_ACK SNMP counterinclude/net/dropreason-core.h include/uapi/linux/snmp.h net/ipv4/proc.c +1 more+7 -34 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchNeal CardwellKuniyuki IwashimaJason Xing
1/3R-b R-b R-b
2/3R-b R-b R-b
3/3R-b T-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/3] tcp: add a new PAWS_ACK drop reason

Current TCP_RFC7323_PAWS drop reason is too generic and can cause confusion.

One common source for these drops are ACK packets coming too late.

A prior packet with payload already changed tp->rcv_nxt.

Add TCP_RFC7323_PAWS_ACK new drop reason, and do not generate a DUPACK for such old ACK.

v2:
- Also add matching LINUX_MIB_PAWS_OLD_ACK SNMP counter.
- fix a typo in one changelog.

Eric Dumazet (3):
tcp: add drop_reason support to tcp_disordered_ack()
tcp: add TCP_RFC7323_PAWS_ACK drop reason
tcp: add LINUX_MIB_PAWS_OLD_ACK SNMP counter

 include/net/dropreason-core.h |  6 +++
 include/uapi/linux/snmp.h     |  1 +
 net/ipv4/proc.c               |  1 +
 net/ipv4/tcp_input.c          | 84 +++++++++++++++++++++--------------
 4 files changed, 59 insertions(+), 33 deletions(-)
Signature · 1 line
2.47.1.613.gc27f4b7a9f-goog