Skip to content

hw/arm/stellaris: Fix overwritten IRQs and cleanups

Philippe Mathieu-Daudé qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/arm/stellaris: Link each board schematichw/arm/stellaris.c+8 -01 reply
2/9hw/arm/stellaris: Constify read-only arrayshw/arm/stellaris.c+3 -31 reply
3/9hw/arm/stellaris: Remove incorrect unimplemented i2c-0 at 0x40002000hw/arm/stellaris.c+0 -21 reply
4/9hw/arm/stellaris: Replace magic numbers by definitionshw/arm/stellaris.c+15 -101 reply
5/9hw/arm/stellaris: Use DEVCAP macro to access DeviceCapability registershw/arm/stellaris.c+29 -81 reply
6/9hw/arm/stellaris: Map both I2C controllershw/arm/stellaris.c+13 -81 reply
7/9hw/arm/stellaris: Only create MPU when availablehw/arm/stellaris.c+3 -01 reply
8/9hw/arm/stellaris: Only map existing devices as unimplementedhw/arm/stellaris.c+15 -51 reply
9/9hw/arm/stellaris: Wire GPTM[#n] output to ADC input #nhw/arm/stellaris.c+17 -91 reply

Reviews trailers per patch

7 of 9 patches have a Reviewed-by or Acked-by.

PatchPeter Maydell
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] hw/arm/stellaris: Fix overwritten IRQs and cleanups

- Remove invalid unimplemented I2C#0
- Add DEVCAP() macro to check DeviceCapability registers
- Check DEVCAP() before creating devices
- Use 4 inputs for ADC, wire each timer output properly
- Improve documentation

Philippe Mathieu-Daudé (9):
hw/arm/stellaris: Link each board schematic hw/arm/stellaris: Constify read-only arrays hw/arm/stellaris: Remove incorrect unimplemented i2c-0 at 0x40002000 hw/arm/stellaris: Replace magic numbers by definitions hw/arm/stellaris: Use DEVCAP macro to access DeviceCapability
registers
hw/arm/stellaris: Map both I2C controllers hw/arm/stellaris: Only create MPU when available hw/arm/stellaris: Only map existing devices as unimplemented hw/arm/stellaris: Wire GPTM[#n] output to ADC input #n

 hw/arm/stellaris.c | 146 +++++++++++++++++++++++++++++++--------------
 1 file changed, 102 insertions(+), 44 deletions(-)
Signature · 1 line
2.47.1