Skip to content

hw/char/serial: Convert to three-phase reset

Philippe Mathieu-Daudé qemu-devel 3 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v22 patches 4 repliesSuperseded
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- SerialState::irq is supposed to be a 'protected' field, do not set it from 'outside' of the object, expose it as QDev GPIO.
- Manually Reset SerialState from parents, register global reset handler for SERIAL_MM (not on qbus)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw/char/serial: Expose SerialState::irq as QDev GPIOhw/char/serial-isa.c hw/char/serial-pci-multi.c hw/char/serial-pci.c +1 more+5 -30 replies
2/2hw/char/serial: Convert to three-phase resethw/char/serial-isa.c hw/char/serial-mm.c hw/char/serial-pci-multi.c +2 more+56 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] hw/char/serial: Convert to three-phase reset

v3 (rework v2's crap):
- SerialState::irq is supposed to be a 'protected' field, do not set it from 'outside' of the object, expose it as QDev GPIO.
- Manually Reset SerialState from parents, register global reset handler for SERIAL_MM (not on qbus)

v2:
- Addressed Paolo's comments from v1 (except &error_abort).

Note, this fixes a bug where serial_realize() was calling serial_reset() -> qemu_irq_lower() while the IRQ was not yet created.

Philippe Mathieu-Daudé (2):
hw/char/serial: Expose SerialState::irq as QDev GPIO hw/char/serial: Convert to three-phase reset

 hw/char/serial-isa.c       | 12 +++++++++++-
 hw/char/serial-mm.c        | 11 +++++++++++
 hw/char/serial-pci-multi.c | 21 ++++++++++++++++++++-
 hw/char/serial-pci.c       | 14 +++++++++++++-
 hw/char/serial.c           | 12 ++++++------
 5 files changed, 61 insertions(+), 9 deletions(-)
Signature · 1 line
2.47.1