Skip to content

Move uid filtering to BPF filters

Ian Rogers bpf linux-perf-users lkml 4 versions – Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest10 patches 5 repliesApplied
  2. v310 patches 7 repliesSuperseded
  3. v212 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches21 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/10perf parse-events filter: Use evsel__find_pmutools/perf/util/parse-events.c+4 -100 replies
2/10perf target: Separate parse_uid into its own functiontools/perf/util/target.c tools/perf/util/target.h+14 -110 replies
3/10perf parse-events: Add parse_uid_filter helpertools/perf/util/parse-events.c tools/perf/util/parse-events.h+33 -13 replies
4/10perf record: Switch user option to use BPF filtertools/perf/builtin-record.c+16 -110 replies
5/10perf tests record: Add basic uid filtering testtools/perf/tests/shell/record.sh+26 -00 replies
6/10perf top: Switch user option to use BPF filtertools/perf/builtin-top.c tools/perf/util/top.c tools/perf/util/top.h+15 -120 replies
7/10perf trace: Switch user option to use BPF filtertools/perf/builtin-trace.c+17 -90 replies
8/10perf bench evlist-open-close: Switch user option to use BPF filtertools/perf/bench/evlist-open-close.c+21 -150 replies
9/10perf target: Remove uid from targettools/perf/builtin-ftrace.c tools/perf/builtin-kvm.c tools/perf/builtin-stat.c +10 more+6 -730 replies
10/10perf thread_map: Remove uid optionstools/perf/tests/event-times.c tools/perf/tests/keep-tracking.c tools/perf/tests/mmap-basic.c +9 more+20 -480 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 00/10] Move uid filtering to BPF filters

Rather than scanning /proc and skipping PIDs based on their UIDs, use BPF filters for uid filtering. The /proc scanning in thread_map is racy as the PID may exit before the perf_event_open causing perf to abort. BPF UID filters are more robust as they avoid the race. The /proc scanning also misses processes starting after the perf command. Add a helper for commands that support UID filtering and wire up. Remove the non-BPF UID filtering support given it doesn't work.

v4: Add a warning message on top of Namhyung's BPF filter error message:
https://lore.kernel.org/lkml/[email protected]/
in the parse_uid_filter helper. In TUI the warning is shown then the BPF error shown, with stdio the warning appears below the BPF errors.

v3: Add lengthier commit messages as requested by Arnaldo. Rebase on
tmp.perf-tools-next.

v2: Add a perf record uid test (Namhyung) and force setting
system-wide for perf trace and perf record (Namhyung). Ensure the uid filter isn't set on tracepoint evsels.

v1: https://lore.kernel.org/lkml/[email protected]/

Ian Rogers (10):
perf parse-events filter: Use evsel__find_pmu
perf target: Separate parse_uid into its own function perf parse-events: Add parse_uid_filter helper
perf record: Switch user option to use BPF filter
perf tests record: Add basic uid filtering test
perf top: Switch user option to use BPF filter
perf trace: Switch user option to use BPF filter
perf bench evlist-open-close: Switch user option to use BPF filter perf target: Remove uid from target
perf thread_map: Remove uid options

 tools/perf/bench/evlist-open-close.c        | 36 ++++++++------
 tools/perf/builtin-ftrace.c                 |  1 -
 tools/perf/builtin-kvm.c                    |  2 -
 tools/perf/builtin-record.c                 | 27 ++++++-----
 tools/perf/builtin-stat.c                   |  4 +-
 tools/perf/builtin-top.c                    | 22 +++++----
 tools/perf/builtin-trace.c                  | 27 +++++++----
 tools/perf/tests/backward-ring-buffer.c     |  1 -
 tools/perf/tests/event-times.c              |  8 ++-
 tools/perf/tests/keep-tracking.c            |  2 +-
 tools/perf/tests/mmap-basic.c               |  2 +-
 tools/perf/tests/openat-syscall-all-cpus.c  |  2 +-
 tools/perf/tests/openat-syscall-tp-fields.c |  1 -
 tools/perf/tests/openat-syscall.c           |  2 +-
 tools/perf/tests/perf-record.c              |  1 -
 tools/perf/tests/perf-time-to-tsc.c         |  2 +-
 tools/perf/tests/shell/record.sh            | 26 ++++++++++
 tools/perf/tests/switch-tracking.c          |  2 +-
 tools/perf/tests/task-exit.c                |  1 -
 tools/perf/tests/thread-map.c               |  2 +-
 tools/perf/util/bpf-filter.c                |  2 +-
 tools/perf/util/evlist.c                    |  3 +-
 tools/perf/util/parse-events.c              | 47 +++++++++++++-----
 tools/perf/util/parse-events.h              |  1 +
 tools/perf/util/python.c                    | 10 ++--
 tools/perf/util/target.c                    | 54 +++------------------
 tools/perf/util/target.h                    | 15 ++----
 tools/perf/util/thread_map.c                | 32 ++----------
 tools/perf/util/thread_map.h                |  6 +--
 tools/perf/util/top.c                       |  4 +-
 tools/perf/util/top.h                       |  1 +
 31 files changed, 164 insertions(+), 182 deletions(-)
Signature · 1 line
2.50.0.rc0.604.gd4ff7b7c86-goog