Skip to content

hw/mips/loongson3: Remove uses of &first_cpu global

Philippe Mathieu-Daudé qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/211 patches 2 repliesIn review
  2. v2 posting 1/219 patches 1 replySuperseded
  3. v123 patches 1 replySuperseded

Changes in v2 from the cover letter

- Reworked patch 2 (rth)

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11hw/mips/loongson3_virt: Factor generic_cpu_reset() outhw/mips/loongson3_virt.c+17 -90 replies
2/11hw/mips/loongson3_virt: Invert vCPU creation order to remove &first_cpuhw/mips/loongson3_virt.c+2 -41 reply
3/11hw/mips/loongson3_virt: Have fw_conf_init() access local loaderparamshw/mips/loongson3_virt.c+6 -60 replies
4/11hw/mips/loongson3_virt: Pass CPU argument to get_cpu_freq_hz()hw/mips/loongson3_virt.c+3 -30 replies
5/11hw/mips/loongson3_bootp: Include missing headershw/mips/loongson3_bootp.c+2 -00 replies
6/11hw/mips/loongson3: Propagate cpu_count to init_loongson_params()hw/mips/loongson3_bootp.c hw/mips/loongson3_bootp.h hw/mips/loongson3_virt.c+8 -50 replies
7/11hw/mips/loongson3_virt: Propagate cpu_count to init_boot_param()hw/mips/loongson3_virt.c+3 -40 replies
8/11hw/mips/loongson3_bootp: Propagate processor_id to init_cpu_info()hw/mips/loongson3_bootp.c+3 -30 replies
9/11hw/mips/loongson3_virt: Propagate processor_id to init_loongson_params()hw/mips/loongson3_bootp.c hw/mips/loongson3_bootp.h hw/mips/loongson3_virt.c+4 -40 replies
10/11hw/mips/loongson3_virt: Propagate %processor_id to init_boot_param()hw/mips/loongson3_virt.c+3 -40 replies
11/11hw/mips/loongson3_bootp: Move to common_ss[]hw/mips/meson.build+2 -10 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/11] hw/mips/loongson3: Remove uses of &first_cpu global

Missing review: #2

Since v1:
- Reworked patch 2 (rth)

Propagate values from machine_init() in order to remove use of globals such &first_cpu and &current_machine.

Philippe Mathieu-Daudé (11):
hw/mips/loongson3_virt: Factor generic_cpu_reset() out hw/mips/loongson3_virt: Invert vCPU creation order to remove
&first_cpu
hw/mips/loongson3_virt: Have fw_conf_init() access local loaderparams hw/mips/loongson3_virt: Pass CPU argument to get_cpu_freq_hz() hw/mips/loongson3_bootp: Include missing headers hw/mips/loongson3: Propagate cpu_count to init_loongson_params() hw/mips/loongson3_virt: Propagate cpu_count to init_boot_param() hw/mips/loongson3_bootp: Propagate processor_id to init_cpu_info() hw/mips/loongson3_virt: Propagate processor_id to
init_loongson_params()
hw/mips/loongson3_virt: Propagate %processor_id to init_boot_param() hw/mips/loongson3_bootp: Move to common_ss[]

 hw/mips/loongson3_bootp.h |  1 +
 hw/mips/loongson3_bootp.c | 16 +++++++-----
 hw/mips/loongson3_virt.c  | 54 ++++++++++++++++++++++-----------------
 hw/mips/meson.build       |  3 ++-
 4 files changed, 42 insertions(+), 32 deletions(-)
Signature · 1 line
2.47.1