Skip to content

bnxt_en: Add NPAR 1.2 and TPH support

Michael Chan netdev 5 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest11 patches 0 repliesApplied 11/11
  2. v410 patches 4 repliesSuperseded
  3. v310 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v210 patches6 repliesSuperseded
v110 patches15 repliesSuperseded

Changes in v5 from the cover letter

Split bnxt_hwrm_tx_ring_free() refactoring from patch #9 into a new patch Remove reset counters increment
Add comments that ring alloc should not fail in this code path Add comments about napi_disable()

Patches in v5 All 11 applied

#Subject and filesSizeRepliesApplied
1/11bnxt_en: Set NPAR 1.2 support when registering with firmwaredrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+6 -00 repliesApplied
2/11bnxt_en: Refactor completion ring allocation logic for P5_PLUS chipsdrivers/net/ethernet/broadcom/bnxt/bnxt.c+21 -230 repliesApplied
3/11bnxt_en: Refactor TX ring allocation logicdrivers/net/ethernet/broadcom/bnxt/bnxt.c+15 -70 repliesApplied
4/11bnxt_en: Refactor completion ring free routinedrivers/net/ethernet/broadcom/bnxt/bnxt.c+16 -100 repliesApplied
5/11bnxt_en: Refactor bnxt_free_tx_rings() to free per TX ringdrivers/net/ethernet/broadcom/bnxt/bnxt.c+61 -540 repliesApplied
6/11bnxt_en: Refactor RX/RX AGG ring parameters setup for P5_PLUSdrivers/net/ethernet/broadcom/bnxt/bnxt.c+28 -300 repliesApplied
7/11bnxt_en: Pass NQ ID to the FW when allocating RX/RX AGG ringsdrivers/net/ethernet/broadcom/bnxt/bnxt.c+3 -10 repliesApplied
8/11bnxt_en: Reallocate RX completion ring for TPH supportdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+34 -60 repliesApplied
9/11bnxt_en: Refactor TX ring free logicdrivers/net/ethernet/broadcom/bnxt/bnxt.c+19 -140 repliesApplied
10/11bnxt_en: Extend queue stop/start for TX ringsdrivers/net/ethernet/broadcom/bnxt/bnxt.c+110 -90 repliesApplied
11/11bnxt_en: Add TPH support in BNXT driverdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+111 -00 repliesApplied

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchSomnath KoturMichal SwiatkowskiAjit KhapardeKalesh APHongguang GaoAndy Gospodarek
1/11R-b R-b
2/11R-b R-b
3/11R-b R-b
4/11R-b R-b
5/11R-b
6/11R-b R-b R-b
7/11R-b R-b R-b
8/11R-b
9/11R-b
10/11R-b R-b
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v5 thread

Cover letter [PATCH net-next v5 00/11] bnxt_en: Add NPAR 1.2 and TPH support

The first patch adds NPAR 1.2 support. Patches 2 to 11 add TPH (TLP Processing Hints) support. These TPH driver patches are new revisions originally posted as part of the TPH PCI patch series. Additional driver refactoring has been done so that we can free and allocate RX completion ring and the TX rings if the channel is a combined channel. We also add napi_disable() and napi_enable() during queue_stop() and queue_start() respectively, and reset for error handling in queue_start().

v5:
Split bnxt_hwrm_tx_ring_free() refactoring from patch #9 into a new patch Remove reset counters increment
Add comments that ring alloc should not fail in this code path Add comments about napi_disable()

v4:
Fix NPAR typo in patch #1 and improve the description of NPAR

https://lore.kernel.org/netdev/[email protected]/

v3:
Fix build bot warning in patch #9
Add MODULE_IMPORT_NS("NETDEV_INTERNAL") to patch #10 Optimize ring operations when TPH is not enabled in patch #8 and #9

https://lore.kernel.org/netdev/[email protected]/

v2:
Major change is error handling in patch #9.

https://lore.kernel.org/netdev/[email protected]/

v1:
https://lore.kernel.org/netdev/[email protected]/

Discussion about adding napi_disable()/napi_enable():

https://lore.kernel.org/netdev/[email protected]/#t

Previous driver series fixing rtnl_lock and empty release function:

https://lore.kernel.org/netdev/[email protected]/

v5 of the PCI series using netdev_rx_queue_restart():

https://lore.kernel.org/netdev/[email protected]/

v1 of the PCI series using open/close:

https://lore.kernel.org/netdev/[email protected]/

Manoj Panicker (1):
bnxt_en: Add TPH support in BNXT driver

Michael Chan (6):
bnxt_en: Set NPAR 1.2 support when registering with firmware
bnxt_en: Refactor completion ring allocation logic for P5_PLUS chips
bnxt_en: Refactor TX ring allocation logic
bnxt_en: Refactor RX/RX AGG ring parameters setup for P5_PLUS
bnxt_en: Pass NQ ID to the FW when allocating RX/RX AGG rings
bnxt_en: Refactor TX ring free logic

Somnath Kotur (4):
bnxt_en: Refactor completion ring free routine
bnxt_en: Refactor bnxt_free_tx_rings() to free per TX ring
bnxt_en: Reallocate RX completion ring for TPH support
bnxt_en: Extend queue stop/start for TX rings

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 554 ++++++++++++++++------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h |   8 +
 2 files changed, 416 insertions(+), 146 deletions(-)
Signature · 1 line
2.30.1