Skip to content

genksyms: fix conflicts and syntax errors in parser

Masahiro Yamada linux-kbuild lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17genksyms: rename m_abstract_declarator to abstract_declaratorscripts/genksyms/parse.y+9 -90 replies
2/17genksyms: rename cvar_qualifier to type_qualifierscripts/genksyms/parse.y+8 -80 replies
3/17genksyms: reduce type_qualifier directly to decl_specifierscripts/genksyms/parse.y+1 -10 replies
4/17genksyms: fix 6 shift/reduce conflicts and 5 reduce/reduce conflictsscripts/genksyms/genksyms.h scripts/genksyms/lex.l scripts/genksyms/parse.y+26 -231 reply
5/17genksyms: fix last 3 shift/reduce conflictsscripts/genksyms/parse.y+20 -80 replies
6/17genksyms: remove Makefile hackscripts/genksyms/Makefile+0 -180 replies
7/17genksyms: restrict direct-abstract-declarator to take one parameter-type-listscripts/genksyms/parse.y+10 -60 replies
8/17genksyms: restrict direct-declarator to take one parameter-type-listscripts/genksyms/parse.y+8 -40 replies
9/17genksyms: record attributes consistently for init-declaratorscripts/genksyms/parse.y+1 -10 replies
10/17genksyms: decouple ATTRIBUTE_PHRASE from type-qualifierscripts/genksyms/parse.y+4 -10 replies
11/17genksyms: fix syntax error for attribute before abstract_declaratorscripts/genksyms/parse.y+4 -40 replies
12/17genksyms: fix syntax error for attribute before nested_declaratorscripts/genksyms/parse.y+2 -20 replies
13/17genksyms: fix syntax error for attribute after abstact_declaratorscripts/genksyms/parse.y+2 -20 replies
14/17genksyms: fix syntax error for attribute after 'struct'scripts/genksyms/lex.l scripts/genksyms/parse.y+11 -60 replies
15/17genksyms: fix syntax error for attribute after 'union'scripts/genksyms/parse.y+5 -50 replies
16/17genksyms: fix syntax error for builtin (u)int*x*_t typesscripts/genksyms/lex.l+1 -00 replies
17/17genksyms: fix syntax error for attribute before init-declaratorscripts/genksyms/parse.y+4 -40 replies

Reviews trailers per patch

None of the 17 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNicolas Schier
SeriesA-b
1/17
2/17
3/17
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/17] genksyms: fix conflicts and syntax errors in parser

This series fixes several long-standing issues in genksyms.

- The parser contains grammatical ambiguities, including both reduce/reduce and shift/reduce conflicts.

- There are several hidden syntax errors
When a syntax error occurs, the type becomes UNKNOWN, and precise CRC calculation becomes impossible.

Masahiro Yamada (17):
genksyms: rename m_abstract_declarator to abstract_declarator
genksyms: rename cvar_qualifier to type_qualifier
genksyms: reduce type_qualifier directly to decl_specifier
genksyms: fix 6 shift/reduce conflicts and 5 reduce/reduce conflicts
genksyms: fix last 3 shift/reduce conflicts
genksyms: remove Makefile hack
genksyms: restrict direct-abstract-declarator to take one
parameter-type-list
genksyms: restrict direct-declarator to take one parameter-type-list
genksyms: record attributes consistently for init-declarator
genksyms: decouple ATTRIBUTE_PHRASE from type-qualifier
genksyms: fix syntax error for attribute before abstract_declarator
genksyms: fix syntax error for attribute before nested_declarator
genksyms: fix syntax error for attribute after abstact_declarator
genksyms: fix syntax error for attribute after 'struct'
genksyms: fix syntax error for attribute after 'union'
genksyms: fix syntax error for builtin (u)int*x*_t types
genksyms: fix syntax error for attribute before init-declarator

 scripts/genksyms/Makefile   |  18 -----
 scripts/genksyms/genksyms.h |   3 +
 scripts/genksyms/lex.l      |  17 +++-
 scripts/genksyms/parse.y    | 150 ++++++++++++++++++++----------------
 4 files changed, 101 insertions(+), 87 deletions(-)
Signature · 1 line
2.43.0