Skip to content

dev: Covnert dev_change_name() to per-netns RTNL.

Kuniyuki Iwashima netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3dev: Acquire netdev_rename_lock before restoring dev->name in dev_change_name().net/core/dev.c+2 -01 replyApplied
2/3dev: Remove devnet_rename_sem.net/core/dev.c+2 -141 replyApplied
3/3dev: Hold rtnl_net_lock() for dev_ifsioc().net/core/dev.c net/core/dev_ioctl.c net/core/rtnl_net_debug.c+22 -261 replyApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric Dumazet
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 net-next 0/3] dev: Covnert dev_change_name() to per-netns RTNL.

Patch 1 adds a missing netdev_rename_lock in dev_change_name() and Patch 2 removes unnecessary devnet_rename_sem there.

Patch 3 replaces RTNL with rtnl_net_lock() in dev_ifsioc(), and now dev_change_name() is always called under per-netns RTNL.

Given it's close to -rc8 and Patch 1 touches the trivial unlikely path, can Patch 1 go into net-next ? Otherwise I'll post Patch 2 & 3 separately in the next cycle.

Kuniyuki Iwashima (3):
dev: Acquire netdev_rename_lock before restoring dev->name in

    dev_change_name().

dev: Remove devnet_rename_sem.
dev: Hold rtnl_net_lock() for dev_ifsioc().

 net/core/dev.c            | 25 ++++++-------------------
 net/core/dev_ioctl.c      | 26 +++++++++++++++++---------
 net/core/rtnl_net_debug.c | 15 +++------------
 3 files changed, 26 insertions(+), 40 deletions(-)
Signature · 1 line
2.39.5 (Apple Git-154)