Skip to content

PCI: Fix the issue of failed speed limit lifting

Jiwei Sun linux-pci lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 3 repliesIn review
  2. v32 patches 2 repliesSuperseded
  3. v22 patches 8 repliesSuperseded

Changes in v4 from the cover letter

- rename the variable name in the macro

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2PCI: Fix the wrong reading of register fieldsdrivers/pci/pci.h+19 -130 replies
2/2PCI: Adjust the position of reading the Link Control 2 registerdrivers/pci/quirks.c+4 -20 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchIlpo Järvinen
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] PCI: Fix the issue of failed speed limit lifting

From: Jiwei Sun <[email protected]>

Since commit de9a6c8d5dbf ("PCI/bwctrl: Add pcie_set_target_speed() to set PCIe Link Speed"), there are two potential issues in the function pcie_failed_link_retrain().

(1) The macro PCIE_LNKCTL2_TLS2SPEED() and PCIE_LNKCAP_SLS2SPEED() just use the link speed field of the registers. However, there are many other different function fields in the Link Control 2 Register or the Link Capabilities Register. If the register value is directly used by the two macros, it may cause getting an error link speed value (PCI_SPEED_UNKNOWN).

(2) In the pcie_failed_link_retrain(), the local variable lnkctl2 is not changed after reading from PCI_EXP_LNKCTL2. It might cause that the removing 2.5GT/s downstream link speed restriction codes are not executed.

In order to avoid the above-mentioned potential issues, only keep link speed field of the two registers before using and reread the Link Control 2 Register before using.

This series focuses on the first patch of the original series [1]. The second one of the original series will submitted via the other single patch.

[1] https://lore.kernel.org/linux-pci/[email protected]/
---
v4 changes:
- rename the variable name in the macro

v3 changes:
- add fix tag in the commit messages of first patch
- add an empty line after the local variable definition in the macro
- adjust the position of reading the Link Control 2 register in the code

v2 changes:
- divide the two issues into different patches
- get fixed inside the macros

Jiwei Sun (2):
PCI: Fix the wrong reading of register fields
PCI: Adjust the position of reading the Link Control 2 register

 drivers/pci/pci.h    | 32 +++++++++++++++++++-------------
 drivers/pci/quirks.c |  6 ++++--
 2 files changed, 23 insertions(+), 15 deletions(-)
Signature · 1 line
2.34.1