Skip to content

RFC target/arm: Constify helpers taking CPUARMState arg

Philippe Mathieu-Daudé qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cpus: Introduce const_cpu_env() and const_env_archcpu()include/exec/cpu-common.h include/hw/core/cpu.h+11 -01 reply
2/2target/arm: Constify lot of helpers taking CPUARMState argumenttarget/arm/cpu-features.h target/arm/cpu.h target/arm/helper.c +4 more+63 -613 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchDaniel Henrique Barboza
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/2] target/arm: Constify helpers taking CPUARMState arg

Hi,

I'd like to enforce some CpuClass handlers to take a const CPUState* argument, but before I need to clean each target. RFC starting with ARM, mostly to get feedback on const_cpu_env() and const_env_archcpu().

Thanks,

Phil.

Based-on: <[email protected]>
"softfloat: Constify helpers returning float_status field"

Philippe Mathieu-Daudé (2):
cpus: Introduce const_cpu_env() and const_env_archcpu() target/arm: Constify lot of helpers taking CPUARMState argument

 include/exec/cpu-common.h |  5 +++
 include/hw/core/cpu.h     |  6 ++++
 target/arm/cpu-features.h |  2 +-
 target/arm/cpu.h          | 71 ++++++++++++++++++++-------------------
 target/arm/internals.h    | 10 +++---
 target/arm/helper.c       | 25 +++++++-------
 target/arm/ptw.c          |  2 +-
 target/arm/tcg/m_helper.c |  8 ++---
 target/arm/vfp_helper.c   |  6 ++--
 9 files changed, 74 insertions(+), 61 deletions(-)
Signature · 1 line
2.47.1