Skip to content

Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

Thomas Huth qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3tests/qtest/test-x86-cpuid-compat.c+0 -182 replies
2/3hw/i386/pc_piix: Remove pc-i440fx-2.4 up to pc-i440fx-2.12docs/about/deprecated.rst docs/about/removed-features.rst docs/interop/firmware.json +2 more+8 -1102 replies
3/3tests/qtest/test-x86-cpuid-compat: Replaced the removed pc-i440fx-2.* machinestests/qtest/test-x86-cpuid-compat.c+17 -170 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchKashyap ChamarthyFabiano RosasPhilippe Mathieu-Daudé
1/3R-b R-b
2/3R-b R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12

While our new auto-disablement of old machine types will only kick in with the next (v10.1) release, the pc-i440fx-2.* machine types have been explicitly marked as deprecated via our old deprecation policy mechanism before (two releases ago), so it should be fine to remove them now already.

Note that we can not do much additional clean ups on top yet since the corresponding q35 machines (which share the same compatibility knobs) are still around and only will be removed for the 10.1 release instead. So the bigger clean-up can only be done for 10.1, but removing the i440fx machine types now will still have at least a small benefit of accelerating our CI a little bit (since we don't have to run tests for these old machine types anymore).

Thomas Huth (3):
tests/qtest/test-x86-cpuid-compat: Remove tests related to

    pc-i440fx-2.3

hw/i386/pc_piix: Remove pc-i440fx-2.4 up to pc-i440fx-2.12 tests/qtest/test-x86-cpuid-compat: Replaced the removed pc-i440fx-2.*
machines

 docs/about/deprecated.rst           |  7 ---
 docs/about/removed-features.rst     |  4 +-
 docs/interop/firmware.json          |  2 +-
 hw/i386/pc_piix.c                   | 95 -----------------------------
 tests/qtest/test-x86-cpuid-compat.c | 52 ++++++----------
 qemu-options.hx                     | 10 +--
 6 files changed, 25 insertions(+), 145 deletions(-)
Signature · 1 line
2.47.1