Skip to content

pinctrl: cy8c95x0: Bugfixes and cleanups

Andy Shevchenko linux-gpio lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 4 repliesIn review
  2. v116 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- dropped wrong patch (Patrick)
- reshuffled fixes from most important to less important (Linus)
- rebased on top of v6.14-rc1

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14pinctrl: cy8c95x0: Fix off-by-one in the regmap range settingsdrivers/pinctrl/pinctrl-cy8c95x0.c+3 -30 replies
2/14pinctrl: cy8c95x0: Avoid accessing reserved registersdrivers/pinctrl/pinctrl-cy8c95x0.c+10 -60 replies
3/14pinctrl: cy8c95x0: Enable regmap locking for debugdrivers/pinctrl/pinctrl-cy8c95x0.c+4 -00 replies
4/14pinctrl: cy8c95x0: Rename PWMSEL to SELPWMdrivers/pinctrl/pinctrl-cy8c95x0.c+7 -70 replies
5/14pinctrl: cy8c95x0: Use better bitmap APIs where appropriatedrivers/pinctrl/pinctrl-cy8c95x0.c+12 -211 reply
6/14pinctrl: cy8c95x0; Switch to use for_each_set_clump8()drivers/pinctrl/pinctrl-cy8c95x0.c+9 -150 replies
7/14pinctrl: cy8c95x0: Transform to cy8c95x0_regmap_read_bits()drivers/pinctrl/pinctrl-cy8c95x0.c+25 -200 replies
8/14pinctrl: cy8c95x0: Remove redundant check in cy8c95x0_regmap_update_bits_base()drivers/pinctrl/pinctrl-cy8c95x0.c+5 -110 replies
9/14pinctrl: cy8c95x0: Replace 'return ret' by 'return 0' in some casesdrivers/pinctrl/pinctrl-cy8c95x0.c+3 -30 replies
10/14pinctrl: cy8c95x0: Initialise boolean variable with boolean valuesdrivers/pinctrl/pinctrl-cy8c95x0.c+2 -20 replies
11/14pinctrl: cy8c95x0: Get rid of cy8c95x0_pinmux_direction() forward declarationdrivers/pinctrl/pinctrl-cy8c95x0.c+25 -290 replies
12/14pinctrl: cy8c95x0: Drop unneeded castingdrivers/pinctrl/pinctrl-cy8c95x0.c+1 -10 replies
13/14pinctrl: cy8c95x0: Separate EEPROM related register definitiosdrivers/pinctrl/pinctrl-cy8c95x0.c+4 -00 replies
14/14pinctrl: cy8c95x0: Fix comment styledrivers/pinctrl/pinctrl-cy8c95x0.c+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/14] pinctrl: cy8c95x0: Bugfixes and cleanups

This a set of the bugfixes and cleanups I have collected so far while testing the driver on Intel Galileo Gen 1 last year.

Patches 1-2 are kinda important fixes, patch 3 is half-half, it helps a lot when debugging, patch 4 is semantically a fix, but can wait. The rest is number of refactoring and cleaning up changes.

Changelog v2:
- dropped wrong patch (Patrick)
- reshuffled fixes from most important to less important (Linus)
- rebased on top of v6.14-rc1

Andy Shevchenko (14):
pinctrl: cy8c95x0: Fix off-by-one in the regmap range settings
pinctrl: cy8c95x0: Avoid accessing reserved registers
pinctrl: cy8c95x0: Enable regmap locking for debug
pinctrl: cy8c95x0: Rename PWMSEL to SELPWM
pinctrl: cy8c95x0: Use better bitmap APIs where appropriate
pinctrl: cy8c95x0; Switch to use for_each_set_clump8()
pinctrl: cy8c95x0: Transform to cy8c95x0_regmap_read_bits()
pinctrl: cy8c95x0: Remove redundant check in

    cy8c95x0_regmap_update_bits_base()

pinctrl: cy8c95x0: Replace 'return ret' by 'return 0' in some cases
pinctrl: cy8c95x0: Initialise boolean variable with boolean values
pinctrl: cy8c95x0: Get rid of cy8c95x0_pinmux_direction() forward
declaration
pinctrl: cy8c95x0: Drop unneeded casting
pinctrl: cy8c95x0: Separate EEPROM related register definitios
pinctrl: cy8c95x0: Fix comment style

 drivers/pinctrl/pinctrl-cy8c95x0.c | 231 ++++++++++++++---------------
 1 file changed, 112 insertions(+), 119 deletions(-)
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac