KVM: x86: pvclock fixes and cleanups
Status from this message: Applied to kvm-x86 pvclock, to start getting coverage in -next. I put this in
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest11 patches 8 repliesApplied
- v110 patches 19 repliesSuperseded
Changes in v2 from the cover letter
- Collect reviews. [Paul, Vitaly]
- Account for the compat offset in xen_get_guest_pvclock().
- Try both the compat and non-compat clocks in kvm_xen_start_timer().
- Fix a horrendous uninitialized variable bug. [Paul]
- Move the kvm_xen_start_timer() change earlier so that it wouldn't be transiently broken due to "version" always being '0'.
- Shuffle patches so that the "set PVCLOCK_GUEST_STOPPED only for kvmclock" is fully isolated from "Don't bleed PVCLOCK_GUEST_STOPPED". [Paul]
Patches in v2 Applied
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Paul Durrant | Vitaly Kuznetsov |
|---|---|---|
| 1/11 | R-b | |
| 2/11 | R-b | |
| 3/11 | R-b | |
| 4/11 | R-b | |
| 5/11 | R-b | |
| 6/11 | R-b | |
| 7/11 | R-b | |
| 8/11 | R-b R-b | |
| 9/11 | R-b | |
| 10/11 | R-b | R-b |
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/11] KVM: x86: pvclock fixes and cleanups
Fix a lockdep splat in KVM's suspend notifier by simply removing a spurious kvm->lock acquisition related to kvmclock, and then try to wrangle KVM's pvclock handling into something approaching sanity (I made the mistake of looking at how KVM handled PVCLOCK_GUEST_STOPPED).
The Xen changes are slightly better tested this time around, though given how many bugs there were in v1, that isn't saying a whole lot.
Case in point, I had to shuffle the scariest patch (at first glance), "KVM: x86/xen: Use guest's copy of pvclock when starting timer", to land earlier in the series, because the existing usage of the cache pvclock's "version" field in kvm_xen_start_timer() relies on the pvclock update to persist _a_ version number to the cache. Eww. :-(
v2:
- Collect reviews. [Paul, Vitaly]
- Account for the compat offset in xen_get_guest_pvclock().
- Try both the compat and non-compat clocks in kvm_xen_start_timer().
- Fix a horrendous uninitialized variable bug. [Paul]
- Move the kvm_xen_start_timer() change earlier so that it wouldn't be transiently broken due to "version" always being '0'.
- Shuffle patches so that the "set PVCLOCK_GUEST_STOPPED only for kvmclock" is fully isolated from "Don't bleed PVCLOCK_GUEST_STOPPED". [Paul]
v1: https://lore.kernel.org/all/[email protected]
Sean Christopherson (11):
KVM: x86: Don't take kvm->lock when iterating over vCPUs in suspend
notifier
KVM: x86: Eliminate "handling" of impossible errors during SUSPEND
KVM: x86: Drop local pvclock_flags variable in kvm_guest_time_update()
KVM: x86: Process "guest stopped request" once per guest time update
KVM: x86/xen: Use guest's copy of pvclock when starting timer
KVM: x86: Don't bleed PVCLOCK_GUEST_STOPPED across PV clocks
KVM: x86: Set PVCLOCK_GUEST_STOPPED only for kvmclock, not for Xen PV
clock
KVM: x86: Pass reference pvclock as a param to
kvm_setup_guest_pvclock()
KVM: x86: Remove per-vCPU "cache" of its reference pvclock
KVM: x86: Setup Hyper-V TSC page before Xen PV clocks (during clock
update)
KVM: x86: Override TSC_STABLE flag for Xen PV clocks in
kvm_guest_time_update()
arch/x86/include/asm/kvm_host.h | 3 +- arch/x86/kvm/x86.c | 115 ++++++++++++++++---------------- arch/x86/kvm/xen.c | 69 +++++++++++++++++-- 3 files changed, 121 insertions(+), 66 deletions(-)
base-commit: eb723766b1030a23c38adf2348b7c3d1409d11f0
Signature · 1 line
2.48.1.362.g079036d154-goog