led: add function naming option from linux
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 3 repliesIn review
- v31 patch 3 repliesSuperseded
- v21 patch 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 1 patch | 2 replies | Superseded |
Changes in v4 from the cover letter
- new in version 4
- remove ./doc/device-tree-bindings/leds/common.txt in
seperate patch as this is now already in ./dts/upstream/Bindings/leds/common.txt
as Tom commented.
measured size impact of patch "led: add function naming option from linux":
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | doc: remove redundant leds bindingsdoc/ | +0 | 1 reply | |
| 2/2 | led: add function naming option from linuxarch/ drivers/ include/ +2 more | +130 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Tom Rini |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] led: add function naming option from linux
in linux we have the option to create the name of a led optionally through the following properties:
- function
- color
- function-enumerator
This series adds support for parsing this properties if there is no label property.
patch 1 is new in this series since v4, which deletes the file doc/device-tree-bindings/leds/common.txt as Tom suggested.
Azure build:
https://dev.azure.com/hs0298/hs/_build/results?buildId=168&view=results
for sandbox64_clang ... sandbox64 target works! The error has nothing ToDo with this patchseries, as it is in dm_test_cmd_hash_md5, which tests content from source files, this series do not touch.
Changes in v4:
- new in version 4
- remove ./doc/device-tree-bindings/leds/common.txt in
seperate patch as this is now already in ./dts/upstream/Bindings/leds/common.txt
as Tom commented.
measured size impact of patch "led: add function naming option from linux":
$ ./u-boot-size-test.sh capricorn_cxg3 --branch led-mainline
[...]
aarch64: (for 1/1 boards) all +886.0 rodata +230.0 text +656.0
capricorn_cxg3 : all +886 rodata +230 text +656
u-boot: add: 1/0, grow: 1/0 bytes: 416/0 (416)
function old new delta
led_post_bind 220 516 +296
led_colors - 120 +120
$ ./u-boot-size-test.sh aristainetos2c --branch led-mainline
[...]
01: Merge patch series "add the support of sha256_hmac and sha256_hkdf"
40: led: add function naming option from linux
arm: (for 2/2 boards) all +557.0 bss +20.0 rodata +161.0 text +376.0
aristainetos2c : all +557 bss +20 rodata +161 text +376
u-boot: add: 1/0, grow: 1/0 bytes: 264/0 (264)
function old new delta
led_post_bind 128 332 +204
led_colors - 60 +60
aristainetos2ccslb: all +557 bss +20 rodata +161 text +376
u-boot: add: 1/0, grow: 1/0 bytes: 264/0 (264)
function old new delta
led_post_bind 128 332 +204
led_colors - 60 +60
- rebase to current HEAD
d8a7100d658. ("Subtree merge tag 'v6.13-dts' of dts repo [1] into dts/upstream")Changes in v3:
- work in comment from Tom:
remove new file include/dt-bindings/leds/common.h in this patch as it is already in dts/upstream/include/dt-bindings/leds/common.h and so the checkpatch warnings from this file are gone! Thanks! Good catch!
remove file include/linux/uapi/linux/uleds.h and
as we only need one define from it, add this define
in include/led.h
Changes in v2:
- remove unused name variable in function led_get_label()
- rebased patch to current HEAD
82d262ae162 ("Merge patch series "MediaTek MT7629 OF_UPSTREAM migration (v2)"")
Heiko Schocher (2):
doc: remove redundant leds bindings
led: add function naming option from linux
arch/sandbox/dts/test.dts | 37 ++++++++++++- doc/device-tree-bindings/leds/common.txt | 23 -------- drivers/led/led-uclass.c | 70 ++++++++++++++++++++++-- include/led.h | 6 ++ test/dm/led.c | 22 +++++++- test/dm/ofnode.c | 2 +- 6 files changed, 130 insertions(+), 30 deletions(-) delete mode 100644 doc/device-tree-bindings/leds/common.txt
Signature · 1 line
2.20.1