Skip to content

Add allocation annotation to more functions

Stephen Hemminger dpdk-dev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest15 patches 1 replyIn review
  2. v516 patches 0 repliesSuperseded
  3. v416 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v315 patches4 repliesSuperseded
v215 patches1 replySuperseded
v115 patches4 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15fib: add allocation function attributeslib/fib/rte_fib.h lib/fib/rte_fib6.h lib/fib/trie.h+32 -250 replies
2/15rib: annotate rib allocation functionslib/rib/rte_rib.h lib/rib/rte_rib6.h+28 -220 replies
3/15hash: add allocation function attributeslib/hash/rte_fbk_hash.h lib/hash/rte_hash.h+26 -210 replies
4/15lpm: add allocation function attributeslib/lpm/rte_lpm.h lib/lpm/rte_lpm6.h+24 -220 replies
5/15acl: add allocation function attributeslib/acl/rte_acl.h+16 -110 replies
6/15bitratestats: add allocation function attributeslib/bitratestats/rte_bitrate.h+12 -100 replies
7/15member: add allocation function attributeslib/member/rte_member.h+12 -120 replies
8/15mempool: add allocation function attributeslib/mempool/rte_mempool.h+20 -170 replies
9/15eventdev: add allocation function attributeslib/eventdev/rte_event_ring.h+14 -130 replies
10/15ring: add allocation function attributeslib/ring/rte_ring.h+13 -100 replies
11/15reorder: add allocation function attributeslib/reorder/rte_reorder.h+13 -110 replies
12/15compressdev: add allocation function attributeslib/compressdev/rte_comp.h+16 -130 replies
13/15telemetry: add allocation function attributeslib/telemetry/rte_telemetry.h+11 -100 replies
14/15sched: add allocation function attributeslib/sched/rte_sched.h+14 -100 replies
15/15doc: add release note about allocation attributesdoc/guides/rel_notes/release_25_03.rst+30 -00 replies

Reviews trailers per patch

6 of 15 patches have a Reviewed-by or Acked-by.

PatchKonstantin AnanyevMorten BrørupVolodymyr FialkoBruce Richardson
1/15
2/15
3/15A-b
4/15
5/15A-b
6/15
7/15
8/15A-b R-b
9/15
10/15A-b
11/15A-b
12/15
13/15A-b
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/15] Add allocation annotation to more functions

This patch series builds on the allocation function attributes added in 24.11 release. These annotations will allow for compiler to flag cases where a pointer is allocated with one function but incorrectly passed to a different free function.

The current code base does this correctly now, but adding attributes will catch future bugs, or errors in user programs.

For each of these patches, the free function prototype needs to be reordered to be before the function attribute of the allocator.

Checkpatch perl script falsely complains in a couple patches because it doesn't really understand C syntax for attributes.

Note: this won't work for functions that are marked experimental. The problem is that function attribute for deallocator can't handle the case of experimental API. Even if the function in question is experimental the use of experimental free function in the attribute attribute causes problems.

v6 - drop the pipeline patch (see note)

Stephen Hemminger (15):
fib: add allocation function attributes
rib: annotate rib allocation functions
hash: add allocation function attributes
lpm: add allocation function attributes
acl: add allocation function attributes
bitratestats: add allocation function attributes
member: add allocation function attributes
mempool: add allocation function attributes
eventdev: add allocation function attributes
ring: add allocation function attributes
reorder: add allocation function attributes
compressdev: add allocation function attributes
telemetry: add allocation function attributes
sched: add allocation function attributes
doc: add release note about allocation attributes

 doc/guides/rel_notes/release_25_03.rst | 30 +++++++++++++++++++++
 lib/acl/rte_acl.h                      | 27 +++++++++++--------
 lib/bitratestats/rte_bitrate.h         | 22 ++++++++-------
 lib/compressdev/rte_comp.h             | 29 +++++++++++---------
 lib/eventdev/rte_event_ring.h          | 27 ++++++++++---------
 lib/fib/rte_fib.h                      | 26 ++++++++++--------
 lib/fib/rte_fib6.h                     | 24 +++++++++--------
 lib/fib/trie.h                         |  7 ++---
 lib/hash/rte_fbk_hash.h                | 25 +++++++++--------
 lib/hash/rte_hash.h                    | 22 ++++++++-------
 lib/lpm/rte_lpm.h                      | 23 ++++++++--------
 lib/lpm/rte_lpm6.h                     | 23 ++++++++--------
 lib/member/rte_member.h                | 24 ++++++++---------
 lib/mempool/rte_mempool.h              | 37 ++++++++++++++------------
 lib/reorder/rte_reorder.h              | 24 +++++++++--------
 lib/rib/rte_rib.h                      | 26 ++++++++++--------
 lib/rib/rte_rib6.h                     | 24 +++++++++--------
 lib/ring/rte_ring.h                    | 23 +++++++++-------
 lib/sched/rte_sched.h                  | 24 ++++++++++-------
 lib/telemetry/rte_telemetry.h          | 21 ++++++++-------
 20 files changed, 281 insertions(+), 207 deletions(-)
Signature · 1 line
2.45.2