Skip to content

Manual backport of overlayfs fixes from v6.6.72

Amir Goldstein linux-fsdevel linux-unionfs stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ovl: pass realinode to ovl_encode_real_fh() instead of realdentryfs/overlayfs/copy_up.c fs/overlayfs/export.c fs/overlayfs/namei.c +1 more+12 -101 reply
2/3ovl: support encoding fid from inode with no aliasfs/overlayfs/export.c+25 -210 replies
3/3fs: relax assertions on failure to encode file handlesfs/notify/fdinfo.c fs/overlayfs/copy_up.c+3 -60 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

Patch[email protected]
1/3
2/3
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 6.6 0/3] Manual backport of overlayfs fixes from v6.6.72

Greg,

Per your request, here is a manual backport of the overlayfs fixes that were applied in v6.6.72 and reverted in v6.6.73.

For the record, this overlayfs series from v6.7 [2] changes subtle internal semantics across overlayfs code, which are not detectable by build error and therefore are a backporting landmine.

This is exactly what happened with the automatic apply of dependecy patch in v6.6.72.

I will try to be extra diligent about review of auto backports below v6.7 from now on.

Luckily, the leaked mount reference was caught by a vfs assertion and promptly reported by Ignat from Cloudflare team.

Thanks!
Amir.

[1] https://lore.kernel.org/stable/2025012123-cable-reburial-568e@gregkh/
[2] https://lore.kernel.org/linux-unionfs/[email protected]/

Amir Goldstein (3):
ovl: pass realinode to ovl_encode_real_fh() instead of realdentry
ovl: support encoding fid from inode with no alias
fs: relax assertions on failure to encode file handles

 fs/notify/fdinfo.c       |  4 +---
 fs/overlayfs/copy_up.c   | 16 ++++++-------
 fs/overlayfs/export.c    | 49 ++++++++++++++++++++++------------------
 fs/overlayfs/namei.c     |  4 ++--
 fs/overlayfs/overlayfs.h |  2 +-
 5 files changed, 39 insertions(+), 36 deletions(-)
Signature · 1 line
2.34.1