Skip to content

fallocate missing fd_offset

“William Roche qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 2 repliesIn review
  2. v21 patch 2 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Changes in v3 from the cover letter

. change the error reporting messages separating start and fd_offset . the local variable is no longer needed

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1system/physmem: take into account fd_offset for file fallocatesystem/physmem.c+7 -52 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchPeter XuDavid Hildenbrand
1/1R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/1] fallocate missing fd_offset

From: William Roche <[email protected]>

Working on the poisoned memory recovery mechanisms with David Hildenbrand, it appeared that the file hole punching done with the memory discard functions are missing the file offset value fd_offset to correctly modify the right file location.

Note that guest_memfd would not currently take into account fd_offset, so I'm adding a comment next the the fallocate use in ram_block_discard_guest_memfd_range().

The version is also checkpatch.pl clean
make check runs fine on both ARM and x86

v1->v2
. replacing the ram_block_discard_guest_memfd_range()
modifications with a comment.
. use a local variable for the global file offset

v2->v3
. change the error reporting messages separating start and fd_offset . the local variable is no longer needed

William Roche (1):
system/physmem: take into account fd_offset for file fallocate

 system/physmem.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
Signature · 1 line
2.43.5