eth: fix calling napi_enable() in atomic context
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 0 repliesApplied 7/7
- v27 patches 3 repliesSuperseded
- v17 patches 16 repliesSuperseded
Changes in v3 from the cover letter
- [patch 1] move the annotation
v2: https://lore.kernel.org/[email protected]
- [patch 1] correct commit msg (can't sleep -> needs to sleep)
- [patch 1] add re-locking annotation to tg3_irq_quiesce()
- [patch 6] actually switch to napi_enable_locked()
- [patch 7] reword the commit msg slightly
v1: https://lore.kernel.org/[email protected]
Patches in v3 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | eth: tg3: fix calling napi_enable() in atomic contextdrivers/ | +31 | 0 replies | Applied |
| 2/7 | eth: forcedeth: remove local wrappers for napi enable/disabledrivers/ | +8 | 0 replies | Applied |
| 3/7 | eth: forcedeth: fix calling napi_enable() in atomic contextdrivers/ | +3 | 0 replies | Applied |
| 4/7 | eth: 8139too: fix calling napi_enable() in atomic contextdrivers/ | +3 | 0 replies | Applied |
| 5/7 | eth: niu: fix calling napi_enable() in atomic contextdrivers/ | +9 | 0 replies | Applied |
| 6/7 | eth: via-rhine: fix calling napi_enable() in atomic contextdrivers/ | +10 | 0 replies | Applied |
| 7/7 | wifi: mt76: move napi_enable() from under BHdrivers/ drivers/ drivers/ +9 more | +69 | 0 replies | Applied |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Eric Dumazet | Michael Chan | Zhu Yanjun | Francois Romieu |
|---|---|---|---|---|
| 1/7 | R-b | R-b | ||
| 2/7 | R-b | A-b | ||
| 3/7 | R-b | A-b | ||
| 4/7 | R-b | A-b | ||
| 5/7 | R-b | |||
| 6/7 | R-b | |||
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH net v3 0/7] eth: fix calling napi_enable() in atomic context
Dan has reported that I missed a lot of drivers which call napi_enable() in atomic with the naive coccinelle search for spin locks:
https://lore.kernel.org/[email protected]
Fix them. Most of the fixes involve taking the netdev_lock() before the spin lock. mt76 is special because we can just move napi_enable() from the BH section.
All patches compile tested only.
v3:
- [patch 1] move the annotation
v2: https://lore.kernel.org/[email protected]
- [patch 1] correct commit msg (can't sleep -> needs to sleep)
- [patch 1] add re-locking annotation to tg3_irq_quiesce()
- [patch 6] actually switch to napi_enable_locked()
- [patch 7] reword the commit msg slightly
v1: https://lore.kernel.org/[email protected]
Jakub Kicinski (7):
eth: tg3: fix calling napi_enable() in atomic context
eth: forcedeth: remove local wrappers for napi enable/disable
eth: forcedeth: fix calling napi_enable() in atomic context
eth: 8139too: fix calling napi_enable() in atomic context
eth: niu: fix calling napi_enable() in atomic context
eth: via-rhine: fix calling napi_enable() in atomic context
wifi: mt76: move napi_enable() from under BH
drivers/net/ethernet/broadcom/tg3.c | 35 ++++++++++++++++--- drivers/net/ethernet/nvidia/forcedeth.c | 32 ++++++----------- drivers/net/ethernet/realtek/8139too.c | 4 ++- drivers/net/ethernet/sun/niu.c | 10 +++++- drivers/net/ethernet/via/via-rhine.c | 11 +++++- .../net/wireless/mediatek/mt76/mt7603/mac.c | 9 +++-- .../net/wireless/mediatek/mt76/mt7615/pci.c | 8 +++-- .../wireless/mediatek/mt76/mt7615/pci_mac.c | 8 +++-- .../net/wireless/mediatek/mt76/mt76x0/pci.c | 8 +++-- .../net/wireless/mediatek/mt76/mt76x02_mmio.c | 8 +++-- .../net/wireless/mediatek/mt76/mt76x2/pci.c | 7 ++-- .../net/wireless/mediatek/mt76/mt7915/mac.c | 17 ++++++--- .../net/wireless/mediatek/mt76/mt7921/pci.c | 7 ++-- .../wireless/mediatek/mt76/mt7921/pci_mac.c | 7 ++-- .../net/wireless/mediatek/mt76/mt7925/pci.c | 7 ++-- .../wireless/mediatek/mt76/mt7925/pci_mac.c | 7 ++-- .../net/wireless/mediatek/mt76/mt7996/mac.c | 12 +++---- 17 files changed, 132 insertions(+), 65 deletions(-)
Signature · 1 line
2.48.1