Skip to content

Support dynamic opening of capstone/llvm

Ian Rogers bpf linux-perf-users lkml llvm 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest15 patches 1 replyIn review
  2. v519 patches 7 repliesSuperseded
  3. v419 patches 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v318 patches16 repliesSuperseded
v217 patches12 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15perf map: Constify objdump offset/address conversion APIstools/perf/util/map.c tools/perf/util/map.h+18 -70 replies
2/15perf capstone: Move capstone functionality into its own filetools/perf/builtin-script.c tools/perf/util/Build tools/perf/util/capstone.c +3 more+569 -4670 replies
3/15perf llvm: Move llvm functionality into its own filetools/perf/util/Build tools/perf/util/disasm.c tools/perf/util/disasm.h +4 more+373 -3110 replies
4/15perf libbfd: Move libbfd functionality to its own filetools/perf/Makefile.config tools/perf/util/Build tools/perf/util/disasm.c +8 more+718 -6590 replies
5/15perf capstone: Remove open_capstone_handletools/perf/util/capstone.c+6 -280 replies
6/15perf capstone: Support for dlopen-ing libcapstone.sotools/perf/util/capstone.c+248 -390 replies
7/15perf llvm: Support for dlopen-ing libLLVM.sotools/perf/Makefile.config tools/perf/Makefile.perf tools/perf/tests/make +3 more+386 -380 replies
8/15perf llvm: Mangle libperf-llvm.so function namestools/perf/Makefile.perf tools/perf/util/llvm-c-helpers.cpp tools/perf/util/llvm-c-helpers.h+36 -200 replies
9/15perf dso: Move read_symbol from llvm/capstone to dsotools/perf/util/capstone.c tools/perf/util/dso.c tools/perf/util/dso.h +1 more+97 -1250 replies
10/15perf dso: Support BPF programs in dso__read_symboltools/perf/util/disasm.c tools/perf/util/dso.c tools/perf/util/libbfd.c +1 more+80 -420 replies
11/15perf llvm: Disassemble cleanuptools/perf/util/llvm.c+20 -120 replies
12/15perf dso: Clean up read_symbol error handlingtools/perf/util/capstone.c tools/perf/util/dso.c tools/perf/util/llvm.c+16 -50 replies
13/15perf disasm: Make ins__scnprintf and ins__is_nop statictools/perf/util/disasm.c tools/perf/util/disasm.h+3 -60 replies
14/15perf srcline: Fallback between addr2line implementationstools/perf/util/Build tools/perf/util/addr2line.c tools/perf/util/addr2line.h +5 more+485 -4810 replies
15/15perf disasm: Remove unused evsel from annotate_argstools/perf/util/annotate.c tools/perf/util/disasm.h+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 00/15] Support dynamic opening of capstone/llvm

Linking against libcapstone and libLLVM can be a significant increase in dependencies and file size if building statically. For something like perf record the disassembler and addr2line functionality won't be used. Support dynamically loading these libraries using dlopen and then calling the appropriate functions found using dlsym.

The patch series:
1) moves the capstone, LLVM and libbfd code to their own C files,
2) simplifies a little the capstone code;
3) adds perf_ variants of the functions that will either directly call the function or use dlsym to discover it;
4) adds BPF JIT disassembly support to in memory disassemblers (LLVM and capstone) by just directing them at the BPF info linear JIT instructions (note this doesn't support source lines);
5) adds fallback to srcline's addr2line so that llvm_addr2line is tried first, then the deprecated libbfd and then the forked command tried next, moving the code for forking out of the main srcline.c file in the process.

The addr2line LLVM functionality is written in C++. To avoid linking against libLLVM for this, a new LIBLLVM_DYNAMIC option is added where the C++ code with the libLLVM dependency will be built into a libperf-llvm.so and that dlsym-ed and called against. Ideally LLVM would extend their C API to avoid this.

v6: Refactor the libbfd along with capstone and LLVM, previous patch
series had tried to avoid this by just removing the deprecated BUILD_NONDISTRO code. Remove the libtracefs removal into its own patch.
v5: Rebase and comment typo fix.
v4: Rebase and addition of a patch removing an unused struct variable.
v3: Add srcline addr2line fallback trying LLVM first then forking a
process. This came up in conversation with Steinar Gunderson <[email protected]>.
Tweak the cover letter message to try to address Andi Kleen's <[email protected]> feedback that the series doesn't really achieve anything.
v2: Add mangling of the function names in libperf-llvm.so to avoid
potential infinite recursion. Add BPF JIT disassembly support to LLVM and capstone. Add/rebase the BUILD_NONDISTRO cleanup onto the series from:
https://lore.kernel.org/lkml/[email protected]/
Some other minor additional clean up.

Ian Rogers (15):
perf map: Constify objdump offset/address conversion APIs perf capstone: Move capstone functionality into its own file perf llvm: Move llvm functionality into its own file perf libbfd: Move libbfd functionality to its own file perf capstone: Remove open_capstone_handle
perf capstone: Support for dlopen-ing libcapstone.so perf llvm: Support for dlopen-ing libLLVM.so
perf llvm: Mangle libperf-llvm.so function names perf dso: Move read_symbol from llvm/capstone to dso perf dso: Support BPF programs in dso__read_symbol perf llvm: Disassemble cleanup
perf dso: Clean up read_symbol error handling
perf disasm: Make ins__scnprintf and ins__is_nop static perf srcline: Fallback between addr2line implementations perf disasm: Remove unused evsel from annotate_args

 tools/perf/Makefile.config         |  14 +
 tools/perf/Makefile.perf           |  24 +-
 tools/perf/builtin-script.c        |   2 -
 tools/perf/tests/make              |   2 +
 tools/perf/util/Build              |   7 +-
 tools/perf/util/addr2line.c        | 439 ++++++++++++++++
 tools/perf/util/addr2line.h        |  20 +
 tools/perf/util/annotate.c         |   1 -
 tools/perf/util/capstone.c         | 682 +++++++++++++++++++++++++
 tools/perf/util/capstone.h         |  24 +
 tools/perf/util/config.c           |   2 +-
 tools/perf/util/disasm.c           | 645 ++----------------------
 tools/perf/util/disasm.h           |   6 +-
 tools/perf/util/disasm_bpf.c       | 195 --------
 tools/perf/util/disasm_bpf.h       |  12 -
 tools/perf/util/dso.c              | 112 +++++
 tools/perf/util/dso.h              |   4 +
 tools/perf/util/libbfd.c           | 600 ++++++++++++++++++++++
 tools/perf/util/libbfd.h           |  83 ++++
 tools/perf/util/llvm-c-helpers.cpp | 120 ++++-
 tools/perf/util/llvm-c-helpers.h   |  24 +-
 tools/perf/util/llvm.c             | 484 ++++++++++++++++++
 tools/perf/util/llvm.h             |  21 +
 tools/perf/util/map.c              |  19 +-
 tools/perf/util/map.h              |   6 +-
 tools/perf/util/print_insn.c       | 117 +----
 tools/perf/util/srcline.c          | 772 ++---------------------------
 tools/perf/util/srcline.h          |   9 +-
 tools/perf/util/symbol-elf.c       | 100 +---
 tools/perf/util/symbol.c           | 131 -----
 30 files changed, 2745 insertions(+), 1932 deletions(-)
 create mode 100644 tools/perf/util/addr2line.c
 create mode 100644 tools/perf/util/addr2line.h
 create mode 100644 tools/perf/util/capstone.c
 create mode 100644 tools/perf/util/capstone.h
 delete mode 100644 tools/perf/util/disasm_bpf.c
 delete mode 100644 tools/perf/util/disasm_bpf.h
 create mode 100644 tools/perf/util/libbfd.c
 create mode 100644 tools/perf/util/libbfd.h
 create mode 100644 tools/perf/util/llvm.c
 create mode 100644 tools/perf/util/llvm.h
Signature · 1 line
2.51.0.570.gb178f27e6d-goog