ASoC: Intel: avs: Add support for MalibouLake configuration
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest11 patches 1 replyIn review
- v211 patches 1 replySuperseded
- v111 patches 2 repliesSuperseded
Changes in v3 from the cover letter
- fixed compilation under X86=n, found out by IKP
Note: no users of cpuid() seem to be honoring COMPILE_TEST currently. In future I'll try to get rid of ugly #ifdef in tgl.c, but that's not in scope of the MBL series
- removed redundant hw_params() op from the pcm3168a board. Not needed for MBL where the codec has its own SYSCLK source
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | ASoC: codecs: pcm3168a: Add ACPI match tablesound/ | +9 | 0 replies | |
| 2/11 | ASoC: codecs: pcm3168a: Relax probing conditionssound/ | +4 | 0 replies | |
| 3/11 | ASoC: codecs: pcm3168a: Allow for 24-bit in provider modesound/ | +3 | 0 replies | |
| 4/11 | ASoC: Intel: avs: Add pcm3168a machine boardsound/ sound/ sound/ | +155 | 0 replies | |
| 5/11 | ASoC: Intel: avs: pcm3168a board selectionsound/ | +15 | 0 replies | |
| 6/11 | ASoC: Intel: avs: Move DSP-boot steps into individual functionssound/ sound/ | +48 | 0 replies | |
| 7/11 | ASoC: Intel: avs: Configure basefw on TGL-based platformssound/ sound/ sound/ | +80 | 0 replies | |
| 8/11 | ASoC: Intel: avs: New gateway configuration mechanismsound/ | +150 | 0 replies | |
| 9/11 | ASoC: Intel: avs: Remove unused gateway configuration codesound/ sound/ | +1 | 0 replies | |
| 10/11 | ASoC: Intel: avs: Add WHM module supportinclude/ sound/ sound/ +2 more | +107 | 0 replies | |
| 11/11 | ALSA: hda: Select avs-driver by default on MBLsound/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 00/11] ASoC: Intel: avs: Add support for MalibouLake configuration
The avs-driver is the go-to driver for Intel Automotive. MalibouLake (MBL) and RedondoLake (RDL) are representatives of the project. These inherit majority of the featureset from RaptorLake-M (RPL-M) and AlderLake-N (ADL-N) respectively. The onboard codec for these is TI's pcm3168a.
In summary, the patchset:
- modifies existing pcm3168a.c to be x86/ACPI friendly
- updates the DSP firmware booting sequence for cAVS 2.5 platforms to improve its behaviour on some specific revisions/steppings of the hardware
- adds new machine board driver, avs_pcm3168a
- adds selector entry for RPL-M devices in intel-dspcfg
While there 'ALSA: hda:' patch within the list, I'd prefer the patchset to go through Mark's tree to avoid conflicts with follow ups to this one.
Longer version:
Currently the pcm3168a is supported on ARM/DT (ti/j721e-evm.c being the only user). To make it x86/ACPI friendly, add relevant ACPI-match table and relax driver's probing conditions.
The default format is 2ch, 24-bits, 48000kHz. As per specification, 24-bits are supported by the chip and it works in production in contrary to what the existing code suggests. A fix is provided to align the code with the spec.
Now, a single DSP firmware binary covers a wide range of platforms - a single one covers AlderLake, RaptorLake and all their derevatires except for AlderLake-N based due to MEU differences. While most of the hardware capabilities are read by the firmware during runtime, some information is not accessible from the DSP level. Provide the HDAudio controller revision/stepping information to the firmware to address that.
With that done, expand number of modules supported with WovHostModule (WHM). WHM is a processing module which is tailored for ultra-low-power scenarios. From software perspective, as most of its config is similar to the Copier module, code reuse is advised. To make the reuse possible, existing gateway configuration code is refactor - not only to add support for WHM but also make it easier to understand. Multiple smaller functions instead of all-in-one one.
Changes in v3:
- fixed compilation under X86=n, found out by IKP
Note: no users of cpuid() seem to be honoring COMPILE_TEST currently. In future I'll try to get rid of ugly #ifdef in tgl.c, but that's not in scope of the MBL series
- removed redundant hw_params() op from the pcm3168a board. Not needed for MBL where the codec has its own SYSCLK source
Changes in v2:
- added missing MODULE_DESCRIPTION() to avs_pcm3168a
Amadeusz Sławiński (1):
ASoC: Intel: avs: Configure basefw on TGL-based platforms
Cezary Rojewski (10):
ASoC: codecs: pcm3168a: Add ACPI match table
ASoC: codecs: pcm3168a: Relax probing conditions
ASoC: codecs: pcm3168a: Allow for 24-bit in provider mode
ASoC: Intel: avs: Add pcm3168a machine board
ASoC: Intel: avs: pcm3168a board selection
ASoC: Intel: avs: Move DSP-boot steps into individual functions
ASoC: Intel: avs: New gateway configuration mechanism
ASoC: Intel: avs: Remove unused gateway configuration code
ASoC: Intel: avs: Add WHM module support
ALSA: hda: Select avs-driver by default on MBL
include/uapi/sound/intel/avs/tokens.h | 7 + sound/hda/intel-dsp-config.c | 4 + sound/soc/codecs/pcm3168a-i2c.c | 9 + sound/soc/codecs/pcm3168a.c | 11 +- sound/soc/intel/avs/avs.h | 1 + sound/soc/intel/avs/board_selection.c | 17 +- sound/soc/intel/avs/boards/Kconfig | 10 + sound/soc/intel/avs/boards/Makefile | 2 + sound/soc/intel/avs/boards/pcm3168a.c | 143 ++++++++++++++ sound/soc/intel/avs/loader.c | 64 ++++-- sound/soc/intel/avs/messages.c | 38 ++++ sound/soc/intel/avs/messages.h | 22 +++ sound/soc/intel/avs/path.c | 271 +++++++++++++++----------- sound/soc/intel/avs/tgl.c | 33 ++++ sound/soc/intel/avs/topology.c | 42 ++++ sound/soc/intel/avs/topology.h | 11 +- 16 files changed, 544 insertions(+), 141 deletions(-) create mode 100644 sound/soc/intel/avs/boards/pcm3168a.c
Signature · 1 line
2.25.1