Skip to content

target/ppc: Move TCG code from excp_helper.c to tcg-excp_helper.c

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 23 repliesIn review
  2. v115 patches 1 replySuperseded

Changes in v2 from the cover letter

- Keep ppc_tcg_hv_emu() within TARGET_PPC64 (patch #10)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15hw/ppc/spapr: Restrict CONFER hypercall to TCGhw/ppc/spapr_hcall.c+2 -01 reply
2/15hw/ppc/spapr: Restrict part of PAGE_INIT hypercall to TCGhw/ppc/spapr_hcall.c+3 -11 reply
3/15target/ppc: Make ppc_ldl_code() declaration publictarget/ppc/excp_helper.c target/ppc/internal.h+3 -11 reply
4/15target/ppc: Move TCG specific exception handlers to tcg-excp_helper.ctarget/ppc/excp_helper.c target/ppc/meson.build target/ppc/tcg-excp_helper.c+203 -1733 replies
5/15target/ppc: Move ppc_ldl_code() to tcg-excp_helper.ctarget/ppc/excp_helper.c target/ppc/tcg-excp_helper.c+18 -212 replies
6/15target/ppc: Ensure powerpc_checkstop() is only called under TCGtarget/ppc/excp_helper.c+2 -43 replies
7/15target/ppc: Restrict powerpc_checkstop() to TCGtarget/ppc/excp_helper.c target/ppc/internal.h target/ppc/tcg-excp_helper.c+31 -271 reply
8/15target/ppc: Remove raise_exception_ra()target/ppc/cpu.h target/ppc/excp_helper.c+0 -82 replies
9/15target/ppc: Restrict exception helpers to TCGtarget/ppc/excp_helper.c target/ppc/tcg-excp_helper.c+38 -342 replies
10/15target/ppc: Restrict ppc_tcg_hv_emu() to TCGtarget/ppc/excp_helper.c target/ppc/internal.h target/ppc/tcg-excp_helper.c+93 -891 reply
11/15target/ppc: Restrict various common helpers to TCGtarget/ppc/excp_helper.c target/ppc/tcg-excp_helper.c+143 -1411 reply
12/15target/ppc: Fix style in excp_helper.ctarget/ppc/excp_helper.c+2 -11 reply
13/15target/ppc: Make powerpc_excp() prototype publictarget/ppc/excp_helper.c target/ppc/internal.h+2 -11 reply
14/15target/ppc: Restrict ATTN / SCV / PMINSN helpers to TCGtarget/ppc/excp_helper.c target/ppc/tcg-excp_helper.c+39 -451 reply
15/15target/ppc: Restrict various system helpers to TCGtarget/ppc/cpu.h target/ppc/excp_helper.c target/ppc/internal.h +1 more+384 -3970 replies

Reviews trailers per patch

10 of 15 patches have a Reviewed-by or Acked-by.

PatchHarsh Prateek Bora
1/15
2/15R-b
3/15R-b
4/15R-b
5/15R-b
6/15
7/15R-b
8/15R-b
9/15
10/15
11/15R-b
12/15R-b
13/15R-b
14/15R-b
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/15] target/ppc: Move TCG code from excp_helper.c to tcg-excp_helper.c

Since v1:
- Keep ppc_tcg_hv_emu() within TARGET_PPC64 (patch #10)

Hi,

This series is a simply a cleanup restricting TCG specific exception-related code to TCG, by moving code to a new unit named 'tcg-excp_helper.c'.

I ended doing it as a preliminary cleanup for the "Extract TCG state from CPUState".

Diffstat shows 1K lines moved, but the patches are trivial to review using 'git-diff --color-moved=dimmed-zebra' option.

Branch published as:
https://gitlab.com/philmd/qemu/-/tree/ppc_excp_extract_tcg

Regards,

Phil.

Philippe Mathieu-Daudé (15):
hw/ppc/spapr: Restrict CONFER hypercall to TCG hw/ppc/spapr: Restrict part of PAGE_INIT hypercall to TCG target/ppc: Make ppc_ldl_code() declaration public target/ppc: Move TCG specific exception handlers to tcg-excp_helper.c target/ppc: Move ppc_ldl_code() to tcg-excp_helper.c target/ppc: Ensure powerpc_checkstop() is only called under TCG target/ppc: Restrict powerpc_checkstop() to TCG target/ppc: Remove raise_exception_ra()
target/ppc: Restrict exception helpers to TCG
target/ppc: Restrict ppc_tcg_hv_emu() to TCG
target/ppc: Restrict various common helpers to TCG target/ppc: Fix style in excp_helper.c
target/ppc: Make powerpc_excp() prototype public target/ppc: Restrict ATTN / SCV / PMINSN helpers to TCG target/ppc: Restrict various system helpers to TCG

 target/ppc/cpu.h             |   5 -
 target/ppc/internal.h        |  11 +-
 hw/ppc/spapr_hcall.c         |   6 +-
 target/ppc/excp_helper.c     | 943 +----------------------------------
 target/ppc/tcg-excp_helper.c | 924 ++++++++++++++++++++++++++++++++++
 target/ppc/meson.build       |   1 +
 6 files changed, 955 insertions(+), 935 deletions(-)
 create mode 100644 target/ppc/tcg-excp_helper.c
Signature · 1 line
2.47.1