Skip to content

serial: port: Fix UPIO_PORT iotype handling

Andy Shevchenko linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6serial: port: Assign ->iotype correctly when ->iobase is setdrivers/tty/serial/serial_port.c+2 -11 reply
2/6serial: port: Always update ->iotype in __uart_read_properties()drivers/tty/serial/serial_port.c+1 -10 replies
3/6serial: port: Make ->iotype validation global in __uart_read_properties()drivers/tty/serial/serial_port.c+5 -40 replies
4/6serial: 8250_of: Remove unneeded ->iotype assignmentdrivers/tty/serial/8250/8250_of.c+0 -10 replies
5/6serial: 8250_platform: Remove unneeded ->iotype assignmentdrivers/tty/serial/8250/8250_platform.c+0 -90 replies
6/6serial: 8250_pnp: Remove unneeded ->iotype assignmentdrivers/tty/serial/8250/8250_pnp.c+0 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/6] serial: port: Fix UPIO_PORT iotype handling

It appears that the conversion to use uart_read_and_validate_port_properties() broke 8250_of driver for the cases when UPIO_PORT is required.

Looking at the code there is an opportunity to clean up it a bit as well, hence this mini-series.

Patches 1 and 2 (and 1 is most important) are the fixes to the helper function followed by patch 3 that makes code robust against possible future changes in the same area.

The top three patches are post-fix cleanups.

This is done in a series, but can be split to fix-series + cleanup-series for the routing to the current and next Linux kernel releases. It's also possible to route all of them as fixes as they are toughly linked to each other and have not much code changes overall.

Andy Shevchenko (6):
serial: port: Assign ->iotype correctly when ->iobase is set
serial: port: Always update ->iotype in __uart_read_properties()
serial: port: Make ->iotype validation global in
__uart_read_properties()
serial: 8250_of: Remove unneeded ->iotype assignment
serial: 8250_platform: Remove unneeded ->iotype assignment
serial: 8250_pnp: Remove unneeded ->iotype assignment

 drivers/tty/serial/8250/8250_of.c       |  1 -
 drivers/tty/serial/8250/8250_platform.c |  9 ---------
 drivers/tty/serial/8250/8250_pnp.c      | 10 ----------
 drivers/tty/serial/serial_port.c        | 12 +++++++-----
 4 files changed, 7 insertions(+), 25 deletions(-)
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac