Skip to content

hw/sysbus/platform-bus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE

Philippe Mathieu-Daudé qemu-devel xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 29 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/sysbus: Use sizeof(BusState) in main_system_bus_create()hw/core/sysbus.c+2 -22 replies
2/9hw/sysbus: Declare QOM types using DEFINE_TYPES() macrohw/core/sysbus.c+17 -223 replies
3/9hw/sysbus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICEhw/core/sysbus.c include/hw/sysbus.h+16 -02 replies
4/9hw/vfio: Have VFIO_PLATFORM devices inherit from DYNAMIC_SYS_BUS_DEVICEhw/vfio/amd-xgbe.c hw/vfio/calxeda-xgmac.c hw/vfio/platform.c+1 -71 reply
5/9hw/display: Have RAMFB device inherit from DYNAMIC_SYS_BUS_DEVICEhw/display/ramfb-standalone.c+1 -22 replies
6/9hw/i386: Have X86_IOMMU devices inherit from DYNAMIC_SYS_BUS_DEVICEhw/i386/amd_iommu.c hw/i386/intel_iommu.c hw/i386/x86-iommu.c+1 -52 replies
7/9hw/net: Have eTSEC device inherit from DYNAMIC_SYS_BUS_DEVICEhw/net/fsl_etsec/etsec.c+1 -33 replies
8/9hw/tpm: Have TPM TIS sysbus device inherit from DYNAMIC_SYS_BUS_DEVICEhw/tpm/tpm_tis_sysbus.c+1 -23 replies
9/9hw/xen: Have legacy Xen backend inherit from DYNAMIC_SYS_BUS_DEVICEhw/xen/xen-legacy-backend.c include/hw/xen/xen_pvdev.h+4 -66 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRichard HendersonAlexander GrafClément Mathieu--DrifBernhard BeschowStefan BergerPhilippe Mathieu-Daudé
SeriesR-b
1/9R-b R-b
2/9R-b R-b
3/9R-b R-b
4/9R-b
5/9R-b R-b
6/9R-b R-b
7/9R-b R-b T-b A-b
8/9R-b R-b R-b
9/9T-b A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 0/9] hw/sysbus/platform-bus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE

Some SysBus devices can optionally be dynamically plugged onto the sysbus-platform-bus (then virtual guests are aware of mmio mapping and IRQs via device tree / ACPI rules).

This series makes these devices explicit by having them implement the DYNAMIC_SYS_BUS_DEVICE class, which only sets 'user_creatable' flag to %true but makes the codebase a bit clearer (IMHO, at least now we can grep for DYNAMIC_SYS_BUS_DEVICE).

Philippe Mathieu-Daudé (9):
hw/sysbus: Use sizeof(BusState) in main_system_bus_create() hw/sysbus: Declare QOM types using DEFINE_TYPES() macro hw/sysbus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE
hw/vfio: Have VFIO_PLATFORM devices inherit from
DYNAMIC_SYS_BUS_DEVICE
hw/display: Have RAMFB device inherit from DYNAMIC_SYS_BUS_DEVICE hw/i386: Have X86_IOMMU devices inherit from DYNAMIC_SYS_BUS_DEVICE hw/net: Have eTSEC device inherit from DYNAMIC_SYS_BUS_DEVICE hw/tpm: Have TPM TIS sysbus device inherit from DYNAMIC_SYS_BUS_DEVICE hw/xen: Have legacy Xen backend inherit from DYNAMIC_SYS_BUS_DEVICE

 include/hw/sysbus.h           |  2 ++
 include/hw/xen/xen_pvdev.h    |  3 +-
 hw/core/sysbus.c              | 53 ++++++++++++++++++++---------------
 hw/display/ramfb-standalone.c |  3 +-
 hw/i386/amd_iommu.c           |  2 --
 hw/i386/intel_iommu.c         |  2 --
 hw/i386/x86-iommu.c           |  2 +-
 hw/net/fsl_etsec/etsec.c      |  4 +--
 hw/tpm/tpm_tis_sysbus.c       |  3 +-
 hw/vfio/amd-xgbe.c            |  2 --
 hw/vfio/calxeda-xgmac.c       |  2 --
 hw/vfio/platform.c            |  4 +--
 hw/xen/xen-legacy-backend.c   |  7 ++---
 13 files changed, 42 insertions(+), 47 deletions(-)
Signature · 1 line
2.47.1