Skip to content

RFC Fix more head.text bugs and improve diagnostic

Ard Biesheuvel lkml 1 version Applied

Status from this message: The following commit has been merged into the x86/urgent branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 11 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2x86/relocs: Improve diagnostic for rejected absolute referencesarch/x86/tools/relocs.c+4 -38 replies
2/2x86/sev: Disable jump tables in SEV startup codearch/x86/coco/sev/Makefile+4 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/2] Fix more head.text bugs and improve diagnostic

From: Ard Biesheuvel <[email protected]>

Linus reports [0] a build issue when using clang, using a config that presumably has IBT and retpolines disabled.

In this case, the following diagnostic is emitted.

Absolute reference to symbol '.rodata' not permitted in .head.text

As Linus explains, this message is not very helpful to the unsuspecting developer, as it does not really pin down the culprit. So improve this by adding the addend and the offset to the error message, and demote it to a warning so the build can complete. This also works around the unhelpful deleting of vmlinux by make when this condition triggers.

Then, fix the actual issue being reported here, which is a true positive and indicates that the resulting build is fatally broken on SEV-SNP.

[0] https://lore.kernel.org/all/CAHk-=wj7k9nvJn6cpa3-5Ciwn2RGyE605BMkjWE4MqnvC9E92A@mail.gmail.com/

Cc Ingo Molnar <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Tom Lendacky <[email protected]>
Cc Nathan Chancellor <[email protected]>

Ard Biesheuvel (2):
x86/relocs: Improve diagnostic for rejected absolute references x86/sev: Disable jump tables in SEV startup code

 arch/x86/coco/sev/Makefile | 4 ++++
 arch/x86/tools/relocs.c    | 7 ++++---
 2 files changed, 8 insertions(+), 3 deletions(-)
Signature · 1 line
2.48.1.262.g85cc9f2d1e-goog