Skip to content

plugins: add tb convenience functions

Luke Craig qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 2 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3plugin: extend API with qemu_plugin_tb_get_insn_by_vaddrinclude/qemu/qemu-plugin.h plugins/api.c+24 -00 replies
2/3plugin: extend API with qemu_plugin_tb_sizeinclude/qemu/qemu-plugin.h plugins/api.c+17 -00 replies
3/3plugins: extend insn test for new convenience functionstests/tcg/plugins/insn.c+10 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPierrick Bouvier
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] plugins: add tb convenience functions

This PR extends the plugin API with two functions which allow convenient access around tbs.

The first, qemu_plugin_tb_size, provides a mechanism for determining the total size of a translation block.

The second, qemu_plugin_tb_get_insn_by_vaddr, allows users to get a reference to an instruction by its virtual address rather than just its index.

In response to feedback from Pierrick I have updated the implementation of qemu_plugin_tb_size.

Additionally, I have added these functions to the insn.c test plugin in response to Alex's feedback.

Lastly, I'll provide a reply to Alex's feeback (repeated below):

Quoted 3 lines

But the general comment is this is an example of tying the plugin API too deeply with the internals of the translator. Why does a plugin need to know what is an implementation detail?

Finding the line between implementation detail and relevant to plugins is challenging, but I submitted this change because I found myself implementing these functions in plugins. If you'd like for me to enumerate examples where knowing the tb_size is relevant to analysis I'd be happy to submit some.

The change relevant from v2 and v3 is adding a sign off on the commits (thank you Perrick).

Luke Craig (3):
plugin: extend API with qemu_plugin_tb_get_insn_by_vaddr
plugin: extend API with qemu_plugin_tb_size
plugins: extend insn test for new convenience functions

 include/qemu/qemu-plugin.h | 21 +++++++++++++++++++++
 plugins/api.c              | 20 ++++++++++++++++++++
 tests/tcg/plugins/insn.c   | 10 ++++++++++
 3 files changed, 51 insertions(+)
Signature · 1 line
2.34.1